fix[react-devtools/ci]: fix configurations for e2e testing (#29016)
This should fix failing DevTools e2e tests on `main`. With these changes, running tests locally successfully passes all cases.
Ruslan Lesiutin committed
May 8, 2024 at 12:04 UTC
e150a324259c5c63ab635b227f601052b133a99f
2 files changed
+3
-11
package.json
+1
-1
@@ -109,7 +109,7 @@
109
},
110
"scripts": {
111
"build": "node ./scripts/rollup/build-all-release-channels.js",
112
- "build-for-devtools": "cross-env RELEASE_CHANNEL=experimental yarn build react/index,react/jsx,react-dom/index,react-dom/client,react-dom/unstable_testing,react-dom/test-utils,react-is,react-debug-tools,scheduler,react-test-renderer,react-refresh,react-art --type=NODE",
112
+ "build-for-devtools": "cross-env RELEASE_CHANNEL=experimental yarn build react/index,react/jsx,react/compiler-runtime,react-dom/index,react-dom/client,react-dom/unstable_testing,react-dom/test-utils,react-is,react-debug-tools,scheduler,react-test-renderer,react-refresh,react-art --type=NODE",
113
"build-for-devtools-dev": "yarn build-for-devtools --type=NODE_DEV",
114
"build-for-devtools-prod": "yarn build-for-devtools --type=NODE_PROD",
115
"linc": "node ./scripts/tasks/linc.js",
packages/react-devtools-shell/webpack-server.js
+2
-10
@@ -124,8 +124,6 @@ const makeConfig = (entry, alias) => ({
124
},
125
});
126
127
-const clientAsSeparateBuild = semver.gte(REACT_VERSION, '19.0.0');
128
-
127
const app = makeConfig(
128
{
129
'app-index': './src/app/index.js',
@@ -144,14 +142,8 @@ const app = makeConfig(
142
react: resolve(builtModulesDir, 'react'),
143
'react-debug-tools': resolve(builtModulesDir, 'react-debug-tools'),
144
'react-devtools-feature-flags': resolveFeatureFlags('shell'),
147
- 'react-dom/client': resolve(
148
- builtModulesDir,
149
- clientAsSeparateBuild ? 'react-dom/unstable_testing' : 'react-dom/client',
150
- ),
151
- 'react-dom': resolve(
152
- builtModulesDir,
153
- clientAsSeparateBuild ? 'react-dom' : 'react-dom/unstable_testing',
154
- ),
145
+ 'react-dom/client': resolve(builtModulesDir, 'react-dom/unstable_testing'),
146
+ 'react-dom': resolve(builtModulesDir, 'react-dom'),
147
'react-is': resolve(builtModulesDir, 'react-is'),
148
scheduler: resolve(builtModulesDir, 'scheduler'),
149
},