Ship enableFabricCompleteRootInCommitPhase (#33064)
This was shipped internally. Cleaning up the flag.
Jack Pope committed
May 5, 2025 at 13:36 UTC
edf550b67936f2c62534ad5549bf580a4f581bd8
9 files changed
+2
-20
packages/react-native-renderer/src/ReactFiberConfigFabric.js
+2
-8
@@ -63,7 +63,6 @@ import {
63
} from './ReactNativeFiberInspector';
64
65
import {
66
- enableFabricCompleteRootInCommitPhase,
66
passChildrenWhenCloningPersistedNodes,
67
enableLazyPublicInstanceInFabric,
68
} from 'shared/ReactFeatureFlags';
@@ -543,19 +542,14 @@ export function finalizeContainerChildren(
542
container: Container,
543
newChildren: ChildSet,
544
): void {
546
- if (!enableFabricCompleteRootInCommitPhase) {
547
- completeRoot(container.containerTag, newChildren);
548
- }
545
+ // Noop - children will be replaced in replaceContainerChildren
546
}
547
548
export function replaceContainerChildren(
549
container: Container,
550
newChildren: ChildSet,
551
): void {
555
- // Noop - children will be replaced in finalizeContainerChildren
556
- if (enableFabricCompleteRootInCommitPhase) {
557
- completeRoot(container.containerTag, newChildren);
558
- }
552
+ completeRoot(container.containerTag, newChildren);
553
}
554
555
export {getClosestInstanceFromNode as getInstanceFromNode};
packages/shared/ReactFeatureFlags.js
-5
@@ -100,11 +100,6 @@ export const enableSuspenseyImages = false;
100
101
export const enableSrcObject = __EXPERIMENTAL__;
102
103
-/**
104
- * Switches the Fabric API from doing layout in commit work instead of complete work.
105
- */
106
-export const enableFabricCompleteRootInCommitPhase = false;
107
-
103
/**
104
* Switches Fiber creation to a simple object instead of a constructor.
105
*/
packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js
-1
@@ -23,7 +23,6 @@ export const enableHiddenSubtreeInsertionEffectCleanup = __VARIANT__;
23
export const enablePersistedModeClonedFlag = __VARIANT__;
24
export const enableShallowPropDiffing = __VARIANT__;
25
export const passChildrenWhenCloningPersistedNodes = __VARIANT__;
26
-export const enableFabricCompleteRootInCommitPhase = __VARIANT__;
26
export const enableSiblingPrerendering = __VARIANT__;
27
export const enableFastAddPropertiesInDiffing = __VARIANT__;
28
export const enableLazyPublicInstanceInFabric = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -20,7 +20,6 @@ const dynamicFlags: DynamicExportsType = (dynamicFlagsUntyped: any);
20
// the exports object every time a flag is read.
21
export const {
22
alwaysThrottleRetries,
23
- enableFabricCompleteRootInCommitPhase,
23
enableHiddenSubtreeInsertionEffectCleanup,
24
enableObjectFiber,
25
enablePersistedModeClonedFlag,
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -30,7 +30,6 @@ export const enableAsyncIterableChildren = false;
30
export const enableCPUSuspense = false;
31
export const enableCreateEventHandleAPI = false;
32
export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
33
-export const enableFabricCompleteRootInCommitPhase = false;
33
export const enableMoveBefore = true;
34
export const enableFizzExternalRuntime = true;
35
export const enableHalt = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -36,7 +36,6 @@ export const enableUseEffectEventHook = false;
36
export const favorSafetyOverHydrationPerf = true;
37
export const enableLegacyFBSupport = false;
38
export const enableMoveBefore = false;
39
-export const enableFabricCompleteRootInCommitPhase = false;
39
export const enableHiddenSubtreeInsertionEffectCleanup = false;
40
export const enableHydrationLaneScheduling = true;
41
packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js
-1
@@ -60,7 +60,6 @@ export const renameElementSymbol = false;
60
export const retryLaneExpirationMs = 5000;
61
export const syncLaneExpirationMs = 250;
62
export const transitionLaneExpirationMs = 5000;
63
-export const enableFabricCompleteRootInCommitPhase = false;
63
export const enableSiblingPrerendering = true;
64
export const enableHydrationLaneScheduling = true;
65
export const enableYieldingBeforePassive = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -39,7 +39,6 @@ export const favorSafetyOverHydrationPerf = true;
39
export const enableLegacyFBSupport = false;
40
export const enableMoveBefore = false;
41
export const enableRenderableContext = false;
42
-export const enableFabricCompleteRootInCommitPhase = false;
42
export const enableHiddenSubtreeInsertionEffectCleanup = true;
43
44
export const enableRetryLaneExpiration = false;
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -48,7 +48,6 @@ export const enableProfilerTimer = __PROFILE__;
48
export const enableProfilerCommitHooks = __PROFILE__;
49
export const enableProfilerNestedUpdatePhase = __PROFILE__;
50
export const enableUpdaterTracking = __PROFILE__;
51
-export const enableFabricCompleteRootInCommitPhase = false;
51
52
export const enableSuspenseAvoidThisFallback = true;
53