@samitouri / QOS-React-2 / commits / 004cb21bbb

Short circuit the logic for exporting a module (#13392)

* short circuit some logic * revert back to ternary operator

Joseph committed Aug 20, 2018 at 14:29 UTC 004cb21bbb5db92734f763b44419d0c4d071c873
14 files changed +14 -32
packages/react-dom/index.fb.js
+1 -1
@@ -11,4 +11,4 @@ const ReactDOMFB = require('./src/client/ReactDOMFB');
11
12 // TODO: decide on the top-level export form.
13 // This is hacky but makes it work with both Rollup and Jest.
14 -module.exports = ReactDOMFB.default ? ReactDOMFB.default : ReactDOMFB;
14 +module.exports = ReactDOMFB.default || ReactDOMFB;
packages/react-dom/index.js
+1 -1
@@ -13,4 +13,4 @@ const ReactDOM = require('./src/client/ReactDOM');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest.
16 -module.exports = ReactDOM.default ? ReactDOM.default : ReactDOM;
16 +module.exports = ReactDOM.default || ReactDOM;
packages/react-dom/server.browser.js
+1 -3
@@ -13,6 +13,4 @@ const ReactDOMServer = require('./src/server/ReactDOMServerBrowser');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest
16 -module.exports = ReactDOMServer.default
17 - ? ReactDOMServer.default
18 - : ReactDOMServer;
16 +module.exports = ReactDOMServer.default || ReactDOMServer;
packages/react-dom/server.node.js
+1 -3
@@ -13,6 +13,4 @@ const ReactDOMServer = require('./src/server/ReactDOMServerNode');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest
16 -module.exports = ReactDOMServer.default
17 - ? ReactDOMServer.default
18 - : ReactDOMServer;
16 +module.exports = ReactDOMServer.default || ReactDOMServer;
packages/react-dom/test-utils.js
+1 -3
@@ -13,6 +13,4 @@ const ReactTestUtils = require('./src/test-utils/ReactTestUtils');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest.
16 -module.exports = ReactTestUtils.default
17 - ? ReactTestUtils.default
18 - : ReactTestUtils;
16 +module.exports = ReactTestUtils.default || ReactTestUtils;
packages/react-native-renderer/fabric.js
+1 -1
@@ -13,4 +13,4 @@ const ReactFabric = require('./src/ReactFabric');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest.
16 -module.exports = ReactFabric.default ? ReactFabric.default : ReactFabric;
16 +module.exports = ReactFabric.default || ReactFabric;
packages/react-native-renderer/index.js
+1 -3
@@ -13,6 +13,4 @@ const ReactNativeRenderer = require('./src/ReactNativeRenderer');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest.
16 -module.exports = ReactNativeRenderer.default
17 - ? ReactNativeRenderer.default
18 - : ReactNativeRenderer;
16 +module.exports = ReactNativeRenderer.default || ReactNativeRenderer;
packages/react-noop-renderer/index.js
+1 -1
@@ -13,4 +13,4 @@ const ReactNoop = require('./src/ReactNoop');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest.
16 -module.exports = ReactNoop.default ? ReactNoop.default : ReactNoop;
16 +module.exports = ReactNoop.default || ReactNoop;
packages/react-noop-renderer/persistent.js
+1 -3
@@ -13,6 +13,4 @@ const ReactNoopPersistent = require('./src/ReactNoopPersistent');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest.
16 -module.exports = ReactNoopPersistent.default
17 - ? ReactNoopPersistent.default
18 - : ReactNoopPersistent;
16 +module.exports = ReactNoopPersistent.default || ReactNoopPersistent;
packages/react-reconciler/index.js
+1 -3
@@ -23,6 +23,4 @@ const ReactFiberReconciler = require('./src/ReactFiberReconciler');
23
24 // TODO: decide on the top-level export form.
25 // This is hacky but makes it work with both Rollup and Jest.
26 -module.exports = ReactFiberReconciler.default
27 - ? ReactFiberReconciler.default
28 - : ReactFiberReconciler;
26 +module.exports = ReactFiberReconciler.default || ReactFiberReconciler;
packages/react-reconciler/persistent.js
+1 -3
@@ -13,6 +13,4 @@ const ReactFiberReconciler = require('./src/ReactFiberReconciler');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest.
16 -module.exports = ReactFiberReconciler.default
17 - ? ReactFiberReconciler.default
18 - : ReactFiberReconciler;
16 +module.exports = ReactFiberReconciler.default || ReactFiberReconciler;
packages/react-test-renderer/index.js
+1 -3
@@ -13,6 +13,4 @@ const ReactTestRenderer = require('./src/ReactTestRenderer');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest.
16 -module.exports = ReactTestRenderer.default
17 - ? ReactTestRenderer.default
18 - : ReactTestRenderer;
16 +module.exports = ReactTestRenderer.default || ReactTestRenderer;
packages/react-test-renderer/shallow.js
+1 -3
@@ -13,6 +13,4 @@ const ReactShallowRenderer = require('./src/ReactShallowRenderer');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest.
16 -module.exports = ReactShallowRenderer.default
17 - ? ReactShallowRenderer.default
18 - : ReactShallowRenderer;
16 +module.exports = ReactShallowRenderer.default || ReactShallowRenderer;
packages/react/index.js
+1 -1
@@ -13,4 +13,4 @@ const React = require('./src/React');
13
14 // TODO: decide on the top-level export form.
15 // This is hacky but makes it work with both Rollup and Jest.
16 -module.exports = React.default ? React.default : React;
16 +module.exports = React.default || React;