Strip comments from UMD_PROD and NODE_PROD builds, not FB_PROD (#9776)
This regressed with the recent addition of RN_* bundles. I was accidentally stripping comments from FB_PROD when I meant to do the opposite. This corrects that mistake. No significant bundle size change occurs when re-running this build against the version prior to the RN_* bundles.
Brian Vaughn committed
May 25, 2017 at 16:24 UTC
108a395f4e5bcb3a49c3e115351477656080a55f
2 files changed
+43
-41
scripts/rollup/build.js
+3
-1
@@ -329,7 +329,9 @@ function getPlugins(
329
mangle: bundleType !== FB_PROD,
330
manglePropertiesOnProd,
331
preserveVersionHeader: bundleType === UMD_PROD,
332
- removeComments: bundleType === FB_PROD,
332
+ // leave comments in for source map debugging purposes
333
+ // they will be stripped as part of FB's build process
334
+ removeComments: bundleType !== FB_PROD,
335
headerSanityCheck,
336
})
337
)
scripts/rollup/results.json
+40
-40
@@ -41,20 +41,20 @@
41
"gzip": 3614
42
},
43
"React-dev.js (FB_DEV)": {
44
- "size": 74104,
45
- "gzip": 18972
44
+ "size": 74115,
45
+ "gzip": 18980
46
},
47
"React-prod.js (FB_PROD)": {
48
- "size": 36836,
49
- "gzip": 9248
48
+ "size": 36847,
49
+ "gzip": 9254
50
},
51
"ReactDOMStack-dev.js (FB_DEV)": {
52
- "size": 497667,
53
- "gzip": 118999
52
+ "size": 497678,
53
+ "gzip": 119007
54
},
55
"ReactDOMStack-prod.js (FB_PROD)": {
56
- "size": 353129,
57
- "gzip": 84773
56
+ "size": 353140,
57
+ "gzip": 84785
58
},
59
"react-dom.development.js (NODE_DEV)": {
60
"size": 550984,
@@ -65,12 +65,12 @@
65
"gzip": 37300
66
},
67
"ReactDOMFiber-dev.js (FB_DEV)": {
68
- "size": 551962,
69
- "gzip": 127141
68
+ "size": 551973,
69
+ "gzip": 127151
70
},
71
"ReactDOMFiber-prod.js (FB_PROD)": {
72
- "size": 411657,
73
- "gzip": 94084
72
+ "size": 411668,
73
+ "gzip": 94091
74
},
75
"react-dom-server.development.js (NODE_DEV)": {
76
"size": 474459,
@@ -81,20 +81,20 @@
81
"gzip": 32782
82
},
83
"ReactDOMServerStack-dev.js (FB_DEV)": {
84
- "size": 455985,
85
- "gzip": 109831
84
+ "size": 455996,
85
+ "gzip": 109840
86
},
87
"ReactDOMServerStack-prod.js (FB_PROD)": {
88
- "size": 334090,
89
- "gzip": 80459
88
+ "size": 334101,
89
+ "gzip": 80467
90
},
91
"ReactARTStack-dev.js (FB_DEV)": {
92
- "size": 143166,
93
- "gzip": 32816
92
+ "size": 143177,
93
+ "gzip": 32825
94
},
95
"ReactARTStack-prod.js (FB_PROD)": {
96
- "size": 101182,
97
- "gzip": 23039
96
+ "size": 101193,
97
+ "gzip": 23049
98
},
99
"react-art.development.js (NODE_DEV)": {
100
"size": 270515,
@@ -105,12 +105,12 @@
105
"gzip": 17391
106
},
107
"ReactARTFiber-dev.js (FB_DEV)": {
108
- "size": 269773,
109
- "gzip": 57593
108
+ "size": 269784,
109
+ "gzip": 57605
110
},
111
"ReactARTFiber-prod.js (FB_PROD)": {
112
- "size": 208053,
113
- "gzip": 43488
112
+ "size": 208064,
113
+ "gzip": 43498
114
},
115
"ReactNativeStack.js (RN)": {
116
"size": 233993,
@@ -121,12 +121,12 @@
121
"gzip": 84001
122
},
123
"ReactTestRendererFiber-dev.js (FB_DEV)": {
124
- "size": 267275,
125
- "gzip": 56465
124
+ "size": 267286,
125
+ "gzip": 56474
126
},
127
"ReactTestRendererStack-dev.js (FB_DEV)": {
128
- "size": 151770,
129
- "gzip": 34846
128
+ "size": 151781,
129
+ "gzip": 34856
130
},
131
"react-noop-renderer.development.js (NODE_DEV)": {
132
"size": 259192,
@@ -141,8 +141,8 @@
141
"gzip": 13569
142
},
143
"ReactTestUtils-dev.js (FB_DEV)": {
144
- "size": 52725,
145
- "gzip": 13564
144
+ "size": 52736,
145
+ "gzip": 13574
146
},
147
"react-test-renderer-stack.development.js (NODE_DEV)": {
148
"size": 152686,
@@ -153,28 +153,28 @@
153
"gzip": 2247
154
},
155
"ReactShallowRenderer-dev.js (FB_DEV)": {
156
- "size": 8063,
157
- "gzip": 2229
156
+ "size": 8074,
157
+ "gzip": 2234
158
},
159
"ReactDOMServerStream-dev.js (FB_DEV)": {
160
- "size": 472917,
161
- "gzip": 113925
160
+ "size": 472928,
161
+ "gzip": 113934
162
},
163
"ReactDOMServerStream-prod.js (FB_PROD)": {
164
- "size": 345920,
165
- "gzip": 83497
164
+ "size": 345931,
165
+ "gzip": 83505
166
},
167
"ReactNativeStack-dev.js (RN_DEV)": {
168
- "size": 350743,
169
- "gzip": 63769
168
+ "size": 351200,
169
+ "gzip": 63905
170
},
171
"ReactNativeStack-prod.js (RN_PROD)": {
172
"size": 269602,
173
"gzip": 46634
174
},
175
"ReactNativeFiber-dev.js (RN_DEV)": {
176
- "size": 327677,
177
- "gzip": 59441
176
+ "size": 328134,
177
+ "gzip": 59569
178
},
179
"ReactNativeFiber-prod.js (RN_PROD)": {
180
"size": 248866,