Remove references to Deletion flag (#20623)
We no longer use the Deletion flag anywhere in the new fork, so we can stop marking it.
Andrew Clark committed
Jan 20, 2021 at 12:18 UTC
11a983fc76192037798d2f93dedf09af97f99884
3 files changed
+2
-19
packages/react-reconciler/src/ReactChildFiber.new.js
+1
-7
@@ -13,12 +13,7 @@ import type {Fiber} from './ReactInternalTypes';
13
import type {Lanes} from './ReactFiberLane.new';
14
15
import getComponentName from 'shared/getComponentName';
16
-import {
17
- Deletion,
18
- ChildDeletion,
19
- Placement,
20
- StaticMask,
21
-} from './ReactFiberFlags';
16
+import {Placement, ChildDeletion} from './ReactFiberFlags';
17
import {
18
getIteratorFn,
19
REACT_ELEMENT_TYPE,
@@ -281,7 +276,6 @@ function ChildReconciler(shouldTrackSideEffects) {
276
returnFiber.firstEffect = returnFiber.lastEffect = childToDelete;
277
}
278
childToDelete.nextEffect = null;
284
- childToDelete.flags = (childToDelete.flags & StaticMask) | Deletion;
279
280
const deletions = returnFiber.deletions;
281
if (deletions === null) {
packages/react-reconciler/src/ReactFiberBeginWork.new.js
-4
@@ -67,7 +67,6 @@ import {
67
DidCapture,
68
Update,
69
Ref,
70
- Deletion,
70
ChildDeletion,
71
ForceUpdateForLegacySuspense,
72
StaticMask,
@@ -2200,8 +2199,6 @@ function updateSuspensePrimaryChildren(
2199
if (currentFallbackChildFragment !== null) {
2200
// Delete the fallback child fragment
2201
currentFallbackChildFragment.nextEffect = null;
2203
- currentFallbackChildFragment.flags =
2204
- (currentFallbackChildFragment.flags & StaticMask) | Deletion;
2202
workInProgress.firstEffect = workInProgress.lastEffect = currentFallbackChildFragment;
2203
const deletions = workInProgress.deletions;
2204
if (deletions === null) {
@@ -3191,7 +3188,6 @@ function remountFiber(
3188
returnFiber.firstEffect = returnFiber.lastEffect = current;
3189
}
3190
current.nextEffect = null;
3194
- current.flags = (current.flags & StaticMask) | Deletion;
3191
3192
const deletions = returnFiber.deletions;
3193
if (deletions === null) {
packages/react-reconciler/src/ReactFiberHydrationContext.new.js
+1
-8
@@ -24,13 +24,7 @@ import {
24
HostRoot,
25
SuspenseComponent,
26
} from './ReactWorkTags';
27
-import {
28
- Deletion,
29
- ChildDeletion,
30
- Placement,
31
- Hydrating,
32
- StaticMask,
33
-} from './ReactFiberFlags';
27
+import {ChildDeletion, Placement, Hydrating} from './ReactFiberFlags';
28
import invariant from 'shared/invariant';
29
30
import {
@@ -130,7 +124,6 @@ function deleteHydratableInstance(
124
const childToDelete = createFiberFromHostInstanceForDeletion();
125
childToDelete.stateNode = instance;
126
childToDelete.return = returnFiber;
133
- childToDelete.flags = (childToDelete.flags & StaticMask) | Deletion;
127
128
// This might seem like it belongs on progressedFirstDeletion. However,
129
// these children are not part of the reconciliation list of children.