@samitouri / QOS-React-2 / commits / 14e4fd1ff2

[Fizz] Move DOM/Native format configs to their respective packages (#20994)

* Move DOM/Native format configs to their respective packages The streaming configs (Node/Browser) are different because they operate at another dimension that exists in each package. * Use escapeTextForBrowser to encode dynamic strings We can now use local dependencies

Sebastian Markbåge committed Mar 13, 2021 at 09:54 UTC 14e4fd1ff2462e8989cb64418be742d7dcfe1549
6 files changed +7 -8
packages/react-dom/src/server/ReactDOMServerFormatConfig.js renamed
+3 -4
@@ -14,6 +14,7 @@ import {
14 convertStringToBuffer,
15 } from 'react-server/src/ReactServerStreamConfig';
16
17 +import escapeTextForBrowser from './escapeTextForBrowser';
18 import invariant from 'shared/invariant';
19
20 // Per response,
@@ -46,13 +47,11 @@ export function createSuspenseBoundaryID(
47 }
48
49 function encodeHTMLIDAttribute(value: string): string {
49 - // TODO: This needs to be encoded for security purposes.
50 - return value;
50 + return escapeTextForBrowser(value);
51 }
52
53 function encodeHTMLTextNode(text: string): string {
54 - // TOOD: This needs to be encoded for security purposes.
55 - return text;
54 + return escapeTextForBrowser(text);
55 }
56
57 export function pushTextInstance(
packages/react-native-renderer/src/server/ReactNativeServerFormatConfig.js renamed
packages/react-server/src/forks/ReactServerFormatConfig.dom-browser.js
+1 -1
@@ -7,4 +7,4 @@
7 * @flow
8 */
9
10 -export * from '../ReactDOMServerFormatConfig';
10 +export * from 'react-dom/src/server/ReactDOMServerFormatConfig';
packages/react-server/src/forks/ReactServerFormatConfig.dom-relay.js
+1 -1
@@ -7,4 +7,4 @@
7 * @flow
8 */
9
10 -export * from '../ReactDOMServerFormatConfig';
10 +export * from 'react-dom/src/server/ReactDOMServerFormatConfig';
packages/react-server/src/forks/ReactServerFormatConfig.dom.js
+1 -1
@@ -7,4 +7,4 @@
7 * @flow
8 */
9
10 -export * from '../ReactDOMServerFormatConfig';
10 +export * from 'react-dom/src/server/ReactDOMServerFormatConfig';
packages/react-server/src/forks/ReactServerFormatConfig.native-relay.js
+1 -1
@@ -7,4 +7,4 @@
7 * @flow
8 */
9
10 -export * from '../ReactNativeServerFormatConfig';
10 +export * from 'react-native-renderer/src/server/ReactNativeServerFormatConfig';