Reset didReceiveUpdate in beginWork (#16359)
This is a bad bug. It means that we sometimes inherit didReceiveUpdate from a previous component's begin. Effectively this only means that we're overrendering in some cases. We should refactor to get rid of this as a global flag.
Sebastian Markbåge committed
Aug 12, 2019 at 14:16 UTC
2716d91ec4757c8d46e5af09066e2db5c8b4d499
1 file changed
+2
packages/react-reconciler/src/ReactFiberBeginWork.js
+2
@@ -2846,6 +2846,8 @@ function beginWork(
2846
workInProgress,
2847
renderExpirationTime,
2848
);
2849
+ } else {
2850
+ didReceiveUpdate = false;
2851
}
2852
} else {
2853
didReceiveUpdate = false;