Remove a flag for style collision warning (#18462)
Dan Abramov committed
Apr 2, 2020 at 11:55 UTC
31734540dc1b507982cae839536f757de964dcd5
10 files changed
-18
packages/react-dom/src/shared/CSSPropertyOperations.js
-6
@@ -11,8 +11,6 @@ import dangerousStyleValue from './dangerousStyleValue';
11
import hyphenateStyleName from './hyphenateStyleName';
12
import warnValidStyle from './warnValidStyle';
13
14
-import {warnAboutShorthandPropertyCollision} from 'shared/ReactFeatureFlags';
15
-
14
/**
15
* Operations for dealing with CSS properties.
16
*/
@@ -128,10 +126,6 @@ export function validateShorthandPropertyCollisionInDev(
126
nextStyles,
127
) {
128
if (__DEV__) {
131
- if (!warnAboutShorthandPropertyCollision) {
132
- return;
133
- }
134
-
129
if (!nextStyles) {
130
return;
131
}
packages/shared/ReactFeatureFlags.js
-4
@@ -40,10 +40,6 @@ export const enableSchedulerDebugging = false;
40
// Disable javascript: URL strings in href for XSS protection.
41
export const disableJavaScriptURLs = false;
42
43
-// Warns when a combination of updates on a dom can cause a style declaration
44
-// that clashes with a previous one https://github.com/facebook/react/pull/14181
45
-export const warnAboutShorthandPropertyCollision = true;
46
-
43
// Experimental React Flare event system and event components support.
44
export const enableDeprecatedFlareAPI = false;
45
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -17,7 +17,6 @@ export const enableSchedulerTracing = __PROFILE__;
17
export const enableSuspenseServerRenderer = false;
18
export const enableSelectiveHydration = false;
19
export const enableBlocksAPI = false;
20
-export const warnAboutShorthandPropertyCollision = true;
20
export const enableSchedulerDebugging = false;
21
export const debugRenderPhaseSideEffectsForStrictMode = true;
22
export const disableJavaScriptURLs = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -21,7 +21,6 @@ export const enableSelectiveHydration = false;
21
export const enableBlocksAPI = false;
22
export const disableJavaScriptURLs = false;
23
export const disableInputAttributeSyncing = false;
24
-export const warnAboutShorthandPropertyCollision = true;
24
export const enableSchedulerDebugging = false;
25
export const enableDeprecatedFlareAPI = false;
26
export const enableFundamentalAPI = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -21,7 +21,6 @@ export const enableSelectiveHydration = false;
21
export const enableBlocksAPI = false;
22
export const disableJavaScriptURLs = false;
23
export const disableInputAttributeSyncing = false;
24
-export const warnAboutShorthandPropertyCollision = true;
24
export const enableSchedulerDebugging = false;
25
export const enableDeprecatedFlareAPI = false;
26
export const enableFundamentalAPI = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -19,7 +19,6 @@ export const enableSchedulerTracing = __PROFILE__;
19
export const enableSuspenseServerRenderer = false;
20
export const enableSelectiveHydration = false;
21
export const enableBlocksAPI = false;
22
-export const warnAboutShorthandPropertyCollision = true;
22
export const enableSchedulerDebugging = false;
23
export const disableJavaScriptURLs = false;
24
export const disableInputAttributeSyncing = false;
packages/shared/forks/ReactFeatureFlags.testing.js
-1
@@ -21,7 +21,6 @@ export const enableSelectiveHydration = false;
21
export const enableBlocksAPI = false;
22
export const disableJavaScriptURLs = false;
23
export const disableInputAttributeSyncing = false;
24
-export const warnAboutShorthandPropertyCollision = true;
24
export const enableSchedulerDebugging = false;
25
export const enableDeprecatedFlareAPI = false;
26
export const enableFundamentalAPI = false;
packages/shared/forks/ReactFeatureFlags.testing.www.js
-1
@@ -21,7 +21,6 @@ export const enableSelectiveHydration = true;
21
export const enableBlocksAPI = true;
22
export const disableJavaScriptURLs = true;
23
export const disableInputAttributeSyncing = false;
24
-export const warnAboutShorthandPropertyCollision = true;
24
export const enableSchedulerDebugging = false;
25
export const enableDeprecatedFlareAPI = true;
26
export const enableFundamentalAPI = false;
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-1
@@ -25,7 +25,6 @@ export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
25
// Update the tests so that they pass in either mode, then set these
26
// to __VARIANT__.
27
export const enableTrustedTypesIntegration = false;
28
-export const warnAboutShorthandPropertyCollision = true;
28
export const disableInputAttributeSyncing = false;
29
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
30
export const enableModernEventSystem = false;
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -19,7 +19,6 @@ export const {
19
disableModulePatternComponents,
20
disableInputAttributeSyncing,
21
enableTrustedTypesIntegration,
22
- warnAboutShorthandPropertyCollision,
22
disableSchedulerTimeoutBasedOnReactExpirationTime,
23
warnAboutSpreadingKeyToJSX,
24
replayFailedUnitOfWorkWithInvokeGuardedCallback,