@samitouri / QOS-React-2 / commits / 375e2d8f33

[babel] Remove babel/plugin-syntax-jsx

Internal version of babel/core doesn't support the `inherits` property, so let's try removing it. The tests still seem to pass, so this might be vestigial from the first iteration of the compiler from last year

Lauren Tan committed Sep 5, 2023 at 12:08 UTC 375e2d8f337293d8162672ea2ab004b1bf178cc0
2 files changed -3
compiler/packages/babel-plugin-react-forget/package.json
-1
@@ -28,7 +28,6 @@
28 },
29 "dependencies": {
30 "@babel/generator": "7.2.0",
31 - "@babel/plugin-syntax-jsx": "^7.18.6",
31 "@babel/types": "^7.19.0",
32 "chalk": "4",
33 "invariant": "^2.2.4",
compiler/packages/babel-plugin-react-forget/src/Babel/BabelPlugin.ts
-2
@@ -8,7 +8,6 @@
8 /// <reference path="./types.d.ts" />
9
10 import type * as BabelCore from "@babel/core";
11 -import jsx from "@babel/plugin-syntax-jsx";
11 import { compileProgram, parsePluginOptions } from "../Entrypoint";
12
13 /**
@@ -21,7 +20,6 @@ export default function ReactForgetBabelPlugin(
20 ): BabelCore.PluginObj {
21 return {
22 name: "react-forget",
24 - inherits: jsx,
23 visitor: {
24 // Note: Babel does some "smart" merging of visitors across plugins, so even if A is inserted
25 // prior to B, if A does not have a Program visitor and B does, B will run first. We always