@samitouri / QOS-React-2 / commits / 380778d296

[test] Cleanup stack assertions in tests mixing React Server and Client (#35316)

Sebastian "Sebbie" Silbermann committed Dec 7, 2025 at 17:45 UTC 380778d296478d675846668f96b0ee3e8f7fe810
3 files changed +19 -38
packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMBrowser-test.js
+9 -24
@@ -2820,15 +2820,16 @@ describe('ReactFlightDOMBrowser', () => {
2820 },
2821 });
2822
2823 + const app = ReactServer.createElement(
2824 + ReactServer.Fragment,
2825 + null,
2826 + ReactServer.createElement(Paragraph, null, 'foo'),
2827 + ReactServer.createElement(Paragraph, null, 'bar'),
2828 + );
2829 const stream = await serverAct(() =>
2830 ReactServerDOMServer.renderToReadableStream(
2831 {
2826 - root: ReactServer.createElement(
2827 - ReactServer.Fragment,
2828 - null,
2829 - ReactServer.createElement(Paragraph, null, 'foo'),
2830 - ReactServer.createElement(Paragraph, null, 'bar'),
2831 - ),
2832 + root: app,
2833 },
2834 webpackMap,
2835 {
@@ -2900,27 +2901,11 @@ describe('ReactFlightDOMBrowser', () => {
2901 "name": "Paragraph",
2902 "props": {},
2903 "stack": [
2903 - [
2904 - "",
2905 - "/packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMBrowser-test.js",
2906 - 2829,
2907 - 27,
2908 - 2823,
2909 - 34,
2910 - ],
2911 - [
2912 - "serverAct",
2913 - "/packages/internal-test-utils/internalAct.js",
2914 - 270,
2915 - 19,
2916 - 231,
2917 - 1,
2918 - ],
2904 [
2905 "Object.<anonymous>",
2906 "/packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMBrowser-test.js",
2922 - 2823,
2923 - 18,
2907 + 2826,
2908 + 19,
2909 2810,
2910 89,
2911 ],
packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMNode-test.js
+6 -10
@@ -1216,11 +1216,7 @@ describe('ReactFlightDOMNode', () => {
1216 const data1 = await getDynamicData1();
1217 const data2 = await getDynamicData2();
1218
1219 - return (
1220 - <p>
1221 - {data1} {data2}
1222 - </p>
1223 - );
1219 + return ReactServer.createElement('p', null, data1, ' ', data2);
1220 }
1221
1222 function App() {
@@ -1350,8 +1346,8 @@ describe('ReactFlightDOMNode', () => {
1346 : '\n') +
1347 ' in body\n' +
1348 ' in html\n' +
1353 - ' in App (file://ReactFlightDOMNode-test.js:1233:25)\n' +
1354 - ' in ClientRoot (ReactFlightDOMNode-test.js:1308:16)',
1349 + ' in App (file://ReactFlightDOMNode-test.js:1229:25)\n' +
1350 + ' in ClientRoot (ReactFlightDOMNode-test.js:1304:16)',
1351 );
1352 } else {
1353 expect(
@@ -1360,7 +1356,7 @@ describe('ReactFlightDOMNode', () => {
1356 '\n' +
1357 ' in body\n' +
1358 ' in html\n' +
1363 - ' in ClientRoot (ReactFlightDOMNode-test.js:1308:16)',
1359 + ' in ClientRoot (ReactFlightDOMNode-test.js:1304:16)',
1360 );
1361 }
1362
@@ -1371,7 +1367,7 @@ describe('ReactFlightDOMNode', () => {
1367 ).toBe(
1368 '\n' +
1369 ' in Dynamic (file://ReactFlightDOMNode-test.js:1216:27)\n' +
1374 - ' in App (file://ReactFlightDOMNode-test.js:1233:25)',
1370 + ' in App (file://ReactFlightDOMNode-test.js:1229:25)',
1371 );
1372 } else {
1373 expect(
@@ -1379,7 +1375,7 @@ describe('ReactFlightDOMNode', () => {
1375 ).toBe(
1376 '' +
1377 '\n' +
1382 - ' in App (file://ReactFlightDOMNode-test.js:1233:25)',
1378 + ' in App (file://ReactFlightDOMNode-test.js:1229:25)',
1379 );
1380 }
1381 } else {
packages/react-server/src/__tests__/ReactFlightAsyncDebugInfo-test.js
+4 -4
@@ -3155,7 +3155,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
3155 }
3156
3157 const stream = ReactServerDOMServer.renderToPipeableStream(
3158 - <Component />,
3158 + ReactServer.createElement(Component),
3159 {},
3160 );
3161
@@ -3192,7 +3192,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
3192 "Object.<anonymous>",
3193 "/packages/react-server/src/__tests__/ReactFlightAsyncDebugInfo-test.js",
3194 3158,
3195 - 40,
3195 + 19,
3196 3146,
3197 36,
3198 ],
@@ -3216,7 +3216,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
3216 "Object.<anonymous>",
3217 "/packages/react-server/src/__tests__/ReactFlightAsyncDebugInfo-test.js",
3218 3158,
3219 - 40,
3219 + 19,
3220 3146,
3221 36,
3222 ],
@@ -3248,7 +3248,7 @@ describe('ReactFlightAsyncDebugInfo', () => {
3248 "Object.<anonymous>",
3249 "/packages/react-server/src/__tests__/ReactFlightAsyncDebugInfo-test.js",
3250 3158,
3251 - 40,
3251 + 19,
3252 3146,
3253 36,
3254 ],