Revert: Enable new passive effect behavior for FB builds (#18467)
Dominic Gannaway committed
Apr 2, 2020 at 16:25 UTC
3966081cf2ffb75cde8239399176f98338511a35
4 files changed
+8
-7
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
+2
-2
@@ -37,8 +37,8 @@ export const enableTrustedTypesIntegration = false;
37
export const disableTextareaChildren = false;
38
export const disableModulePatternComponents = false;
39
export const warnUnstableRenderSubtreeIntoContainer = false;
40
-export const deferPassiveEffectCleanupDuringUnmount = true;
41
-export const runAllPassiveEffectDestroysBeforeCreates = true;
40
+export const deferPassiveEffectCleanupDuringUnmount = false;
41
+export const runAllPassiveEffectDestroysBeforeCreates = false;
42
export const enableModernEventSystem = false;
43
export const warnAboutSpreadingKeyToJSX = false;
44
export const enableLegacyFBSupport = false;
packages/shared/forks/ReactFeatureFlags.testing.www.js
+2
-2
@@ -37,8 +37,8 @@ export const enableTrustedTypesIntegration = false;
37
export const disableTextareaChildren = __EXPERIMENTAL__;
38
export const disableModulePatternComponents = true;
39
export const warnUnstableRenderSubtreeIntoContainer = false;
40
-export const deferPassiveEffectCleanupDuringUnmount = true;
41
-export const runAllPassiveEffectDestroysBeforeCreates = true;
40
+export const deferPassiveEffectCleanupDuringUnmount = false;
41
+export const runAllPassiveEffectDestroysBeforeCreates = false;
42
export const enableModernEventSystem = false;
43
export const warnAboutSpreadingKeyToJSX = false;
44
export const enableLegacyFBSupport = !__EXPERIMENTAL__;
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
+2
@@ -13,6 +13,8 @@
13
// Use __VARIANT__ to simulate a GK. The tests will be run twice: once
14
// with the __VARIANT__ set to `true`, and once set to `false`.
15
16
+export const deferPassiveEffectCleanupDuringUnmount = __VARIANT__;
17
+export const runAllPassiveEffectDestroysBeforeCreates = __VARIANT__;
18
export const warnAboutSpreadingKeyToJSX = __VARIANT__;
19
export const disableModulePatternComponents = __VARIANT__;
20
export const disableInputAttributeSyncing = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.www.js
+2
-3
@@ -16,9 +16,11 @@ const dynamicFeatureFlags: DynamicFeatureFlags = require('ReactFeatureFlags');
16
17
export const {
18
debugRenderPhaseSideEffectsForStrictMode,
19
+ deferPassiveEffectCleanupDuringUnmount,
20
disableModulePatternComponents,
21
disableInputAttributeSyncing,
22
enableTrustedTypesIntegration,
23
+ runAllPassiveEffectDestroysBeforeCreates,
24
disableSchedulerTimeoutBasedOnReactExpirationTime,
25
warnAboutSpreadingKeyToJSX,
26
replayFailedUnitOfWorkWithInvokeGuardedCallback,
@@ -77,9 +79,6 @@ export const throwEarlyForMysteriousError = false;
79
// to the correct value.
80
export const enableNewReconciler = __VARIANT__;
81
80
-export const deferPassiveEffectCleanupDuringUnmount = true;
81
-export const runAllPassiveEffectDestroysBeforeCreates = true;
82
-
82
// Flow magic to verify the exports of this file match the original version.
83
// eslint-disable-next-line no-unused-vars
84
type Check<_X, Y: _X, X: Y = _X> = null;