Disable avoidThisFallback support in Fizz (#23224)
* disable fizz avoidThisFallback support * true
salazarm committed
Feb 1, 2022 at 18:22 UTC
3a44621296e866eb86123fa5777975765138e633
11 files changed
+12
-3
packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js
+1
-1
@@ -1526,7 +1526,7 @@ describe('ReactDOMFizzServer', () => {
1526
expect(getVisibleChildren(container)).toEqual(<div>Hello</div>);
1527
});
1528
1529
- // @gate experimental && enableSuspenseAvoidThisFallback
1529
+ // @gate experimental && enableSuspenseAvoidThisFallbackFizz
1530
it('should respect unstable_avoidThisFallback', async () => {
1531
const resolved = {
1532
0: false,
packages/react-server/src/ReactFizzServer.js
+2
-2
@@ -113,7 +113,7 @@ import {
113
warnAboutDefaultPropsOnFunctionComponents,
114
enableScopeAPI,
115
enableLazyElements,
116
- enableSuspenseAvoidThisFallback,
116
+ enableSuspenseAvoidThisFallbackFizz,
117
} from 'shared/ReactFeatureFlags';
118
119
import getComponentNameFromType from 'shared/getComponentNameFromType';
@@ -1027,7 +1027,7 @@ function renderElement(
1027
// eslint-disable-next-line-no-fallthrough
1028
case REACT_SUSPENSE_TYPE: {
1029
if (
1030
- enableSuspenseAvoidThisFallback &&
1030
+ enableSuspenseAvoidThisFallbackFizz &&
1031
props.unstable_avoidThisFallback === true
1032
) {
1033
renderBackupSuspenseBoundary(request, task, props);
packages/shared/ReactFeatureFlags.js
+1
@@ -102,6 +102,7 @@ export const warnAboutSpreadingKeyToJSX = false;
102
export const warnOnSubscriptionInsideStartTransition = false;
103
104
export const enableSuspenseAvoidThisFallback = false;
105
+export const enableSuspenseAvoidThisFallbackFizz = false;
106
107
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
108
packages/shared/forks/ReactFeatureFlags.native-fb.js
+1
@@ -50,6 +50,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
50
export const warnAboutSpreadingKeyToJSX = false;
51
export const warnOnSubscriptionInsideStartTransition = false;
52
export const enableSuspenseAvoidThisFallback = false;
53
+export const enableSuspenseAvoidThisFallbackFizz = false;
54
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
55
export const enableClientRenderFallbackOnHydrationMismatch = true;
56
export const enableComponentStackLocations = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
+1
@@ -41,6 +41,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
41
export const warnAboutSpreadingKeyToJSX = false;
42
export const warnOnSubscriptionInsideStartTransition = false;
43
export const enableSuspenseAvoidThisFallback = false;
44
+export const enableSuspenseAvoidThisFallbackFizz = false;
45
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
46
export const enableClientRenderFallbackOnHydrationMismatch = true;
47
export const enableComponentStackLocations = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
+1
@@ -41,6 +41,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
41
export const warnAboutSpreadingKeyToJSX = false;
42
export const warnOnSubscriptionInsideStartTransition = false;
43
export const enableSuspenseAvoidThisFallback = false;
44
+export const enableSuspenseAvoidThisFallbackFizz = false;
45
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
46
export const enableClientRenderFallbackOnHydrationMismatch = true;
47
export const enableComponentStackLocations = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
+1
@@ -51,6 +51,7 @@ export const enableNewReconciler = false;
51
export const deferRenderPhaseUpdateToNextBatch = false;
52
export const warnOnSubscriptionInsideStartTransition = false;
53
export const enableSuspenseAvoidThisFallback = false;
54
+export const enableSuspenseAvoidThisFallbackFizz = false;
55
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
56
export const enableClientRenderFallbackOnHydrationMismatch = true;
57
export const enableStrictEffects = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
+1
@@ -41,6 +41,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
41
export const warnAboutSpreadingKeyToJSX = false;
42
export const warnOnSubscriptionInsideStartTransition = false;
43
export const enableSuspenseAvoidThisFallback = true;
44
+export const enableSuspenseAvoidThisFallbackFizz = false;
45
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
46
export const enableClientRenderFallbackOnHydrationMismatch = true;
47
export const enableComponentStackLocations = true;
packages/shared/forks/ReactFeatureFlags.testing.js
+1
@@ -41,6 +41,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
41
export const warnAboutSpreadingKeyToJSX = false;
42
export const warnOnSubscriptionInsideStartTransition = false;
43
export const enableSuspenseAvoidThisFallback = false;
44
+export const enableSuspenseAvoidThisFallbackFizz = false;
45
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
46
export const enableClientRenderFallbackOnHydrationMismatch = true;
47
export const enableComponentStackLocations = true;
packages/shared/forks/ReactFeatureFlags.testing.www.js
+1
@@ -41,6 +41,7 @@ export const warnUnstableRenderSubtreeIntoContainer = false;
41
export const warnAboutSpreadingKeyToJSX = false;
42
export const warnOnSubscriptionInsideStartTransition = false;
43
export const enableSuspenseAvoidThisFallback = true;
44
+export const enableSuspenseAvoidThisFallbackFizz = false;
45
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
46
export const enableClientRenderFallbackOnHydrationMismatch = true;
47
export const enableComponentStackLocations = true;
packages/shared/forks/ReactFeatureFlags.www.js
+1
@@ -51,6 +51,7 @@ export const enableUpdaterTracking = __PROFILE__;
51
52
export const enableSuspenseLayoutEffectSemantics = true;
53
export const enableSuspenseAvoidThisFallback = true;
54
+export const enableSuspenseAvoidThisFallbackFizz = false;
55
56
// Logs additional User Timing API marks for use with an experimental profiling tool.
57
export const enableSchedulingProfiler =