Remove disableNativeComponentFrames (#26490)
## Overview I'm landing this flag internally so we can delete this
Ricky committed
Mar 28, 2023 at 09:46 UTC
41b4714f195868193ddfb2a89d2373b1c61387f4
9 files changed
+2
-14
packages/shared/ReactComponentStackFrame.js
+2
-5
@@ -10,10 +10,7 @@
10
import type {Source} from 'shared/ReactElementType';
11
import type {LazyComponent} from 'react/src/ReactLazy';
12
13
-import {
14
- enableComponentStackLocations,
15
- disableNativeComponentFrames,
16
-} from 'shared/ReactFeatureFlags';
13
+import {enableComponentStackLocations} from 'shared/ReactFeatureFlags';
14
15
import {
16
REACT_SUSPENSE_TYPE,
@@ -68,7 +65,7 @@ export function describeNativeComponentFrame(
65
construct: boolean,
66
): string {
67
// If something asked for a stack inside a fake render, it should get ignored.
71
- if (disableNativeComponentFrames || !fn || reentry) {
68
+ if (!fn || reentry) {
69
return '';
70
}
71
packages/shared/ReactFeatureFlags.js
-2
@@ -230,8 +230,6 @@ export const enableDebugTracing = false;
230
// Track which Fiber(s) schedule render work.
231
export const enableUpdaterTracking = __PROFILE__;
232
233
-// Only enabled in RN, related to enableComponentStackLocations
234
-export const disableNativeComponentFrames = false;
233
export const enableServerContext = true;
234
235
// Internal only.
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -58,7 +58,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
58
export const enableComponentStackLocations = false;
59
export const enableLegacyFBSupport = false;
60
export const enableFilterEmptyStringAttributesDOM = false;
61
-export const disableNativeComponentFrames = false;
61
export const skipUnmountedBoundaries = false;
62
export const enableGetInspectorDataForInstanceInProduction = true;
63
export const deferRenderPhaseUpdateToNextBatch = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -48,7 +48,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
48
export const enableComponentStackLocations = false;
49
export const enableLegacyFBSupport = false;
50
export const enableFilterEmptyStringAttributesDOM = false;
51
-export const disableNativeComponentFrames = false;
51
export const skipUnmountedBoundaries = false;
52
export const enableGetInspectorDataForInstanceInProduction = false;
53
export const deferRenderPhaseUpdateToNextBatch = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -48,7 +48,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
48
export const enableComponentStackLocations = true;
49
export const enableLegacyFBSupport = false;
50
export const enableFilterEmptyStringAttributesDOM = false;
51
-export const disableNativeComponentFrames = false;
51
export const skipUnmountedBoundaries = false;
52
export const enableGetInspectorDataForInstanceInProduction = false;
53
export const deferRenderPhaseUpdateToNextBatch = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
-1
@@ -39,7 +39,6 @@ export const disableModulePatternComponents = false;
39
export const enableComponentStackLocations = false;
40
export const enableLegacyFBSupport = false;
41
export const enableFilterEmptyStringAttributesDOM = false;
42
-export const disableNativeComponentFrames = false;
42
export const skipUnmountedBoundaries = false;
43
export const enableGetInspectorDataForInstanceInProduction = false;
44
export const deferRenderPhaseUpdateToNextBatch = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -48,7 +48,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
48
export const enableComponentStackLocations = true;
49
export const enableLegacyFBSupport = false;
50
export const enableFilterEmptyStringAttributesDOM = true;
51
-export const disableNativeComponentFrames = false;
51
export const skipUnmountedBoundaries = false;
52
export const enableGetInspectorDataForInstanceInProduction = false;
53
export const deferRenderPhaseUpdateToNextBatch = false;
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-1
@@ -59,6 +59,5 @@ export const revertRemovalOfSiblingPrerendering = false;
59
// Update the tests so that they pass in either mode, then set these
60
// to __VARIANT__.
61
export const enableTrustedTypesIntegration = false;
62
-export const disableNativeComponentFrames = false;
62
// You probably *don't* want to add more hardcoded ones.
63
// Instead, try to add them above with the __VARIANT__ value.
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -25,7 +25,6 @@ export const {
25
enableDebugTracing,
26
skipUnmountedBoundaries,
27
enableUseRefAccessWarning,
28
- disableNativeComponentFrames,
28
disableSchedulerTimeoutInWorkLoop,
29
enableLazyContextPropagation,
30
enableUnifiedSyncLane,