fix to input a number value to props
Toru Kobayashi committed
Jul 14, 2019 at 23:11 UTC
41c00cb0cb0920e7d3ae1a1c0bb984e9d6a0f565
1 file changed
+6
-4
src/devtools/views/Components/EditableValue.js
+6
-4
@@ -33,8 +33,6 @@ export default function EditableValue({
33
if (dataType === 'boolean') {
34
setEditableValue(target.checked);
35
overrideValueFn(path, target.checked);
36
- } else if (dataType === 'number') {
37
- setEditableValue(parseFloat(target.value));
36
} else {
37
setEditableValue(target.value);
38
}
@@ -60,7 +58,11 @@ export default function EditableValue({
58
const { key } = event;
59
60
if (key === 'Enter') {
63
- overrideValueFn(path, editableValue);
61
+ if (dataType === 'number') {
62
+ overrideValueFn(path, parseFloat(editableValue));
63
+ } else {
64
+ overrideValueFn(path, editableValue);
65
+ }
66
67
// Don't reset the pending change flag here.
68
// The inspected fiber won't be updated until after the next "inspectElement" message.
@@ -70,7 +72,7 @@ export default function EditableValue({
72
setHasPendingChanges(false);
73
}
74
},
73
- [path, editableValue, overrideValueFn, value]
75
+ [path, editableValue, overrideValueFn, value, dataType]
76
);
77
78
// Render different input types based on the dataType