Remove unused event plugin registrationNamesKeys
Ben Alpert committed
Dec 1, 2013 at 22:28 UTC
4323ab095fd56eae960f681768ad7ec54b7590f0
2 files changed
+2
-9
src/event/EventPluginRegistry.js
-7
@@ -113,7 +113,6 @@ function publishRegistrationName(registrationName, PluginModule) {
113
registrationName
114
);
115
EventPluginRegistry.registrationNames[registrationName] = PluginModule;
116
- EventPluginRegistry.registrationNamesKeys.push(registrationName);
116
}
117
118
/**
@@ -133,11 +132,6 @@ var EventPluginRegistry = {
132
*/
133
registrationNames: {},
134
136
- /**
137
- * The keys of `registrationNames`.
138
- */
139
- registrationNamesKeys: [],
140
-
135
/**
136
* Injects an ordering of plugins (by plugin name). This allows the ordering
137
* to be decoupled from injection of the actual plugins so that ordering is
@@ -236,7 +230,6 @@ var EventPluginRegistry = {
230
delete registrationNames[registrationName];
231
}
232
}
239
- EventPluginRegistry.registrationNamesKeys.length = 0;
233
}
234
235
};
src/event/__tests__/EventPluginRegistry-test.js
+2
-2
@@ -174,13 +174,13 @@ describe('EventPluginRegistry', function() {
174
EventPluginRegistry.injectEventPluginsByName({one: OnePlugin});
175
EventPluginRegistry.injectEventPluginOrder(['one', 'two']);
176
177
- expect(EventPluginRegistry.registrationNamesKeys.length).toBe(2);
177
+ expect(Object.keys(EventPluginRegistry.registrationNames).length).toBe(2);
178
expect(EventPluginRegistry.registrationNames.onClick).toBe(OnePlugin);
179
expect(EventPluginRegistry.registrationNames.onFocus).toBe(OnePlugin);
180
181
EventPluginRegistry.injectEventPluginsByName({two: TwoPlugin});
182
183
- expect(EventPluginRegistry.registrationNamesKeys.length).toBe(4);
183
+ expect(Object.keys(EventPluginRegistry.registrationNames).length).toBe(4);
184
expect(EventPluginRegistry.registrationNames.onMagicBubble).toBe(TwoPlugin);
185
expect(
186
EventPluginRegistry.registrationNames.onMagicCapture