Remove allow transparency (#10823)
* Remove allowTransparency attribute `allowtransparency` is an Internet Explorer-only attribute that controls the background transparency of an iFrame. When set to true, it respects the background color of the iFrame. When set to false, it sets the background color to that of the document. This feature was removed in IE9 - falling out of React's support commitment. Developers that have somehow figured out how to get IE8 to work with React 16.x can still use `allowtransparency="true"`, since React now supports unrecognized attributes. * Use correct attribute script location * Use new UMD bundles in attribute fixtures * Update attribute snapshot * Blank for CI
Nathan Hunzaker committed
Sep 28, 2017 at 07:53 UTC
4472442708e2648a8f3352a9f1daaa9031002a83
6 files changed
+4
-39
fixtures/attribute-behavior/AttributeTableSnapshot.md
-25
@@ -473,31 +473,6 @@
473
| `allowReorder=(null)`| (initial)| `<null>` |
474
| `allowReorder=(undefined)`| (initial)| `<null>` |
475
476
-## `allowTransparency` (on `<path>` inside `<svg>`)
477
-| Test Case | Flags | Result |
478
-| --- | --- | --- |
479
-| `allowTransparency=(string)`| (changed)| `"a string"` |
480
-| `allowTransparency=(empty string)`| (changed)| `<empty string>` |
481
-| `allowTransparency=(array with string)`| (changed)| `"string"` |
482
-| `allowTransparency=(empty array)`| (changed)| `<empty string>` |
483
-| `allowTransparency=(object)`| (changed)| `"result of toString()"` |
484
-| `allowTransparency=(numeric string)`| (changed)| `"42"` |
485
-| `allowTransparency=(-1)`| (changed)| `"-1"` |
486
-| `allowTransparency=(0)`| (changed)| `"0"` |
487
-| `allowTransparency=(integer)`| (changed)| `"1"` |
488
-| `allowTransparency=(NaN)`| (changed, warning)| `"NaN"` |
489
-| `allowTransparency=(float)`| (changed)| `"99.99"` |
490
-| `allowTransparency=(true)`| (changed)| `"true"` |
491
-| `allowTransparency=(false)`| (changed)| `"false"` |
492
-| `allowTransparency=(string 'true')`| (changed)| `"true"` |
493
-| `allowTransparency=(string 'false')`| (changed)| `"false"` |
494
-| `allowTransparency=(string 'on')`| (changed)| `"on"` |
495
-| `allowTransparency=(string 'off')`| (changed)| `"off"` |
496
-| `allowTransparency=(symbol)`| (initial, warning, ssr error, ssr mismatch)| `<null>` |
497
-| `allowTransparency=(function)`| (initial, warning, ssr mismatch)| `<null>` |
498
-| `allowTransparency=(null)`| (initial)| `<null>` |
499
-| `allowTransparency=(undefined)`| (initial)| `<null>` |
500
-
476
## `alphabetic` (on `<font-face>` inside `<svg>`)
477
| Test Case | Flags | Result |
478
| --- | --- | --- |
fixtures/attribute-behavior/README.md
+1
-1
@@ -8,7 +8,7 @@
8
9
## Instructions
10
11
-`cd scripts/attribute-behavior && yarn install && yarn start`
11
+`cd fixtures/attribute-behavior && yarn install && yarn start`
12
13
## Interpretation
14
fixtures/attribute-behavior/src/App.js
+3
-3
@@ -753,9 +753,9 @@ class App extends React.Component {
753
754
async componentDidMount() {
755
const sources = {
756
- ReactStable: 'https://unpkg.com/react@latest/dist/react.js',
757
- ReactDOMStable: 'https://unpkg.com/react-dom@latest/dist/react-dom.js',
758
- ReactDOMServerStable: 'https://unpkg.com/react-dom@latest/dist/react-dom-server.js',
756
+ ReactStable: 'https://unpkg.com/react@latest/umd/react.development.js',
757
+ ReactDOMStable: 'https://unpkg.com/react-dom@latest/umd/react-dom.development.js',
758
+ ReactDOMServerStable: 'https://unpkg.com/react-dom@latest/umd/react-dom-server.browser.development.js',
759
ReactNext: '/react.development.js',
760
ReactDOMNext: '/react-dom.development.js',
761
ReactDOMServerNext: '/react-dom-server.browser.development.js',
fixtures/attribute-behavior/src/attributes.js
-6
@@ -92,12 +92,6 @@ const attributes = [
92
tagName: 'switch',
93
read: getSVGAttribute('allowReorder'),
94
},
95
- {
96
- name: 'allowTransparency',
97
- containerTagName: 'svg',
98
- tagName: 'path',
99
- read: getSVGAttribute('allowtransparency'),
100
- },
95
{
96
name: 'alphabetic',
97
containerTagName: 'svg',
src/renderers/dom/shared/HTMLDOMPropertyConfig.js
-3
@@ -26,9 +26,6 @@ var HTMLDOMPropertyConfig = {
26
// name warnings.
27
Properties: {
28
allowFullScreen: HAS_BOOLEAN_VALUE,
29
- // IE only true/false iFrame attribute
30
- // https://msdn.microsoft.com/en-us/library/ms533072(v=vs.85).aspx
31
- allowTransparency: HAS_STRING_BOOLEAN_VALUE,
29
// specifies target context for links with `preload` type
30
async: HAS_BOOLEAN_VALUE,
31
// autoFocus is polyfilled/normalized by AutoFocusUtils
src/renderers/dom/shared/hooks/possibleStandardNames.js
-1
@@ -18,7 +18,6 @@ var possibleStandardNames = {
18
accesskey: 'accessKey',
19
action: 'action',
20
allowfullscreen: 'allowFullScreen',
21
- allowtransparency: 'allowTransparency',
21
alt: 'alt',
22
as: 'as',
23
async: 'async',