@samitouri / QOS-React-2 / commits / 44cdfd6b7a

Use ReactVersions module as package allowlist (#21613)

Instead of keeping a separate allowlist in sync, we use ReactVersions.js as the source of truth for which packages get published.

Andrew Clark committed Jun 3, 2021 at 11:45 UTC 44cdfd6b7a0f5a4949866a24f65179760b3767d1
2 files changed +4 -35
ReactVersions.js
-1
@@ -50,7 +50,6 @@ const experimentalPackages = [
50 'react-fs',
51 'react-pg',
52 'react-server-dom-webpack',
53 - 'react-server',
53 ];
54
55 // TODO: Export a map of every package and its version.
scripts/release/utils.js
+4 -34
@@ -11,6 +11,7 @@ const {join} = require('path');
11 const createLogger = require('progress-estimator');
12 const prompt = require('prompt-promise');
13 const theme = require('./theme');
14 +const {stablePackages, experimentalPackages} = require('../../ReactVersions');
15
16 // https://www.npmjs.com/package/progress-estimator#configuration
17 const logger = createLogger({
@@ -132,42 +133,11 @@ const getCommitFromCurrentBuild = async () => {
133 };
134
135 const getPublicPackages = isExperimental => {
135 - // TODO: Use ReactVersions.js as source of truth.
136 + const packageNames = Object.keys(stablePackages);
137 if (isExperimental) {
137 - return [
138 - 'create-subscription',
139 - 'eslint-plugin-react-hooks',
140 - 'jest-react',
141 - 'react',
142 - 'react-art',
143 - 'react-dom',
144 - 'react-is',
145 - 'react-reconciler',
146 - 'react-refresh',
147 - 'react-test-renderer',
148 - 'use-subscription',
149 - 'scheduler',
150 - 'react-fetch',
151 - 'react-fs',
152 - 'react-pg',
153 - 'react-server-dom-webpack',
154 - ];
155 - } else {
156 - return [
157 - 'create-subscription',
158 - 'eslint-plugin-react-hooks',
159 - 'jest-react',
160 - 'react',
161 - 'react-art',
162 - 'react-dom',
163 - 'react-is',
164 - 'react-reconciler',
165 - 'react-refresh',
166 - 'react-test-renderer',
167 - 'use-subscription',
168 - 'scheduler',
169 - ];
138 + packageNames.push(...experimentalPackages);
139 }
140 + return packageNames;
141 };
142
143 const handleError = error => {