Revert "update hideOrUnhideAllChildren to hide portals that aren't wrapped in a host component (#16992)" (#17011)
This reverts commit de2edc268db827f5110fc56cba240b7eb7301787.
Luna Ruan committed
Oct 3, 2019 at 17:22 UTC
4bc52ef0dfbb0389cc20b65cef0645afb7b85445
2 files changed
-30
packages/react-dom/src/__tests__/ReactDOMSuspensePlaceholder-test.js
-23
@@ -104,29 +104,6 @@ describe('ReactDOMSuspensePlaceholder', () => {
104
expect(window.getComputedStyle(divs[2].current).display).toEqual('inline');
105
});
106
107
- it('hides and unhides child portals', async () => {
108
- const portalContainer = document.createElement('div');
109
- function Component() {
110
- return ReactDOM.createPortal(<span />, portalContainer);
111
- }
112
-
113
- function App() {
114
- return (
115
- <Suspense fallback={<Text text="Loading..." />}>
116
- <AsyncText ms={500} text="A" />
117
- <Component />
118
- </Suspense>
119
- );
120
- }
121
-
122
- ReactDOM.render(<App />, container);
123
- expect(window.getComputedStyle(portalContainer).display).toEqual('none');
124
-
125
- await advanceTimers(500);
126
- Scheduler.unstable_flushAll();
127
- expect(window.getComputedStyle(portalContainer).display).toEqual('block');
128
- });
129
-
107
it('hides and unhides timed out text nodes', async () => {
108
function App() {
109
return (
packages/react-reconciler/src/ReactFiberCommitWork.js
-7
@@ -645,13 +645,6 @@ function hideOrUnhideAllChildren(finishedWork, isHidden) {
645
} else {
646
unhideInstance(node.stateNode, node.memoizedProps);
647
}
648
- } else if (node.tag === HostPortal) {
649
- const instance = node.stateNode.containerInfo;
650
- if (isHidden) {
651
- hideInstance(instance);
652
- } else {
653
- unhideInstance(instance, node.memoizedProps);
654
- }
648
} else if (node.tag === HostText) {
649
const instance = node.stateNode;
650
if (isHidden) {