@samitouri / QOS-React-2 / commits / 4d1bfcc8e1

Fix renderToStaticMarkup invariant

Max committed Feb 28, 2016 at 22:33 UTC 4d1bfcc8e153fec6180324fa79006bc1c351ebd9
2 files changed +9 -6
src/renderers/dom/server/ReactServerRendering.js
+8 -5
@@ -28,11 +28,6 @@ var invariant = require('invariant');
28 * @return {string} the HTML markup
29 */
30 function renderToStringImpl(element, makeStaticMarkup) {
31 - invariant(
32 - ReactElement.isValidElement(element),
33 - 'renderToString(): You must pass a valid ReactElement.'
34 - );
35 -
31 var transaction;
32 try {
33 ReactUpdates.injection.injectBatchingStrategy(ReactServerBatchingStrategy);
@@ -61,10 +56,18 @@ function renderToStringImpl(element, makeStaticMarkup) {
56 }
57
58 function renderToString(element) {
59 + invariant(
60 + ReactElement.isValidElement(element),
61 + 'renderToString(): You must pass a valid ReactElement.'
62 + );
63 return renderToStringImpl(element, false);
64 }
65
66 function renderToStaticMarkup(element) {
67 + invariant(
68 + ReactElement.isValidElement(element),
69 + 'renderToStaticMarkup(): You must pass a valid ReactElement.'
70 + );
71 return renderToStringImpl(element, true);
72 }
73
src/renderers/dom/server/__tests__/ReactServerRendering-test.js
+1 -1
@@ -360,7 +360,7 @@ describe('ReactServerRendering', function() {
360 'not a component'
361 )
362 ).toThrow(
363 - 'renderToString(): You must pass a valid ReactElement.'
363 + 'renderToStaticMarkup(): You must pass a valid ReactElement.'
364 );
365 });
366