@samitouri / QOS-React-2 / commits / 4d6d4b54d6

Fix ReactDOMTextarea missing "rows" and "cols" attribute, incorrect "size" property

Andreas Svensson committed Nov 12, 2013 at 11:25 UTC 4d6d4b54d67478623b58f5f6c0eca49401b5b4f1
1 file changed +4 -1
src/dom/DefaultDOMPropertyConfig.js
+4 -1
@@ -26,6 +26,7 @@ var MUST_USE_ATTRIBUTE = DOMProperty.injection.MUST_USE_ATTRIBUTE;
26 var MUST_USE_PROPERTY = DOMProperty.injection.MUST_USE_PROPERTY;
27 var HAS_BOOLEAN_VALUE = DOMProperty.injection.HAS_BOOLEAN_VALUE;
28 var HAS_SIDE_EFFECTS = DOMProperty.injection.HAS_SIDE_EFFECTS;
29 +var HAS_POSITIVE_NUMERIC_VALUE = DOMProperty.injection.HAS_POSITIVE_NUMERIC_VALUE;
30
31 var DefaultDOMPropertyConfig = {
32 isCustomAttribute: RegExp.prototype.test.bind(
@@ -50,6 +51,7 @@ var DefaultDOMPropertyConfig = {
51 charSet: MUST_USE_ATTRIBUTE,
52 checked: MUST_USE_PROPERTY | HAS_BOOLEAN_VALUE,
53 className: MUST_USE_PROPERTY,
54 + cols: MUST_USE_ATTRIBUTE | HAS_POSITIVE_NUMERIC_VALUE,
55 colSpan: null,
56 content: null,
57 contentEditable: null,
@@ -89,11 +91,12 @@ var DefaultDOMPropertyConfig = {
91 rel: null,
92 required: HAS_BOOLEAN_VALUE,
93 role: MUST_USE_ATTRIBUTE,
94 + rows: MUST_USE_ATTRIBUTE | HAS_POSITIVE_NUMERIC_VALUE,
95 rowSpan: null,
96 scrollLeft: MUST_USE_PROPERTY,
97 scrollTop: MUST_USE_PROPERTY,
98 selected: MUST_USE_PROPERTY | HAS_BOOLEAN_VALUE,
96 - size: null,
99 + size: MUST_USE_ATTRIBUTE | HAS_POSITIVE_NUMERIC_VALUE,
100 spellCheck: null,
101 src: null,
102 step: null,