Remove temporary CircleCI workaround (#26855)
There was a CircleCI bug that prevented the sizebot job from accessing the artifacts API. I had added a temporary workaround to pull from a mirror instead. This seems to have been fixed, so I can remove the workaround.
Andrew Clark committed
May 25, 2023 at 13:38 UTC
4daccade04ae54339463546e06f07db56a646bd4
1 file changed
+4
-25
.circleci/config.yml
+4
-25
@@ -151,32 +151,11 @@ jobs:
151
- setup_node_modules
152
- run:
153
name: Download artifacts for base revision
154
- # TODO: The download-experimental-build.js script works by fetching
155
- # artifacts from CI. CircleCI recently updated this endpoint to
156
- # require an auth token. This is a problem for PR branches, where
157
- # sizebot needs to run, because we don't want to leak the token to
158
- # arbitrary code written by an outside contributor.
159
- #
160
- # This only affects PR branches. CI workflows that run on the main
161
- # branch are allowed to access environment variables, because only those
162
- # with push access can land code in main.
163
- #
164
- # As a temporary workaround, we'll fetch the assets from a mirror.
165
- # Need to figure out a longer term solution for this.
166
- #
167
- # Original code
168
- #
169
- # command: |
170
- # git fetch origin main
171
- # cd ./scripts/release && yarn && cd ../../
172
- # scripts/release/download-experimental-build.js --commit=$(git merge-base HEAD origin/main) --allowBrokenCI
173
- # mv ./build ./base-build
174
- #
175
- # Workaround. Fetch the artifacts from react-builds.vercel.app. This
176
- # is the same app that hosts the sizebot diff previews.
154
command: |
178
- curl -L --retry 60 --retry-delay 10 --retry-max-time 600 https://react-builds.vercel.app/api/commits/$(git merge-base HEAD origin/main)/artifacts/build.tgz | tar -xz
179
- mv ./build ./base-build
155
+ git fetch origin main
156
+ cd ./scripts/release && yarn && cd ../../
157
+ scripts/release/download-experimental-build.js --commit=$(git merge-base HEAD origin/main) --allowBrokenCI
158
+ mv ./build ./base-build
159
160
- run:
161
# TODO: The `download-experimental-build` script copies the npm