[DevTools] Remove Welcome dialog (#16834)
Dan Abramov committed
Sep 19, 2019 at 16:41 UTC
4ddcb8e1344630a63c10790d8e24e1194a1abdce
6 files changed
-119
packages/react-devtools-core/src/standalone.js
-12
@@ -40,11 +40,6 @@ let nodeWaitingToConnectHTML: string = '';
40
let projectRoots: Array<string> = [];
41
let statusListener: StatusListener = (message: string) => {};
42
43
-// Unlike browser extension users, people using the standalone have actively installed version 4,
44
-// So we probably don't need to show them a changelog notice.
45
-// We should give embedded users (e.g. Nuclide, Sonar) a way of showing this dialog though.
46
-let showWelcomeToTheNewDevToolsDialog: boolean = false;
47
-
43
function setContentDOMNode(value: HTMLElement) {
44
node = value;
45
@@ -63,11 +58,6 @@ function setStatusListener(value: StatusListener) {
58
return DevtoolsUI;
59
}
60
66
-function setShowWelcomeToTheNewDevToolsDialog(value: boolean) {
67
- showWelcomeToTheNewDevToolsDialog = value;
68
- return DevtoolsUI;
69
-}
70
-
61
let bridge: FrontendBridge | null = null;
62
let store: Store | null = null;
63
let root = null;
@@ -108,7 +98,6 @@ function reload() {
98
bridge: ((bridge: any): FrontendBridge),
99
canViewElementSourceFunction,
100
showTabBar: true,
111
- showWelcomeToTheNewDevToolsDialog,
101
store: ((store: any): Store),
102
warnIfLegacyBackendDetected: true,
103
viewElementSourceFunction,
@@ -318,7 +307,6 @@ const DevtoolsUI = {
307
connectToSocket,
308
setContentDOMNode,
309
setProjectRoots,
321
- setShowWelcomeToTheNewDevToolsDialog,
310
setStatusListener,
311
startServer,
312
};
packages/react-devtools-extensions/src/main.js
-1
@@ -161,7 +161,6 @@ function createPanelIfReactLoaded() {
161
overrideTab,
162
profilerPortalContainer,
163
showTabBar: false,
164
- showWelcomeToTheNewDevToolsDialog: true,
164
store,
165
viewElementSourceFunction,
166
}),
packages/react-devtools-shared/src/devtools/views/DevTools.js
-6
@@ -25,7 +25,6 @@ import {ProfilerContextController} from './Profiler/ProfilerContext';
25
import {ModalDialogContextController} from './ModalDialog';
26
import ReactLogo from './ReactLogo';
27
import WarnIfLegacyBackendDetected from './WarnIfLegacyBackendDetected';
28
-import ShowWelcomeToTheNewDevToolsDialog from './ShowWelcomeToTheNewDevToolsDialog';
28
29
import styles from './DevTools.css';
30
@@ -50,7 +49,6 @@ export type Props = {|
49
canViewElementSourceFunction?: ?CanViewElementSource,
50
defaultTab?: TabID,
51
showTabBar?: boolean,
53
- showWelcomeToTheNewDevToolsDialog?: boolean,
52
store: Store,
53
warnIfLegacyBackendDetected?: boolean,
54
viewElementSourceFunction?: ?ViewElementSource,
@@ -92,7 +90,6 @@ export default function DevTools({
90
overrideTab,
91
profilerPortalContainer,
92
showTabBar = false,
95
- showWelcomeToTheNewDevToolsDialog = false,
93
store,
94
warnIfLegacyBackendDetected = false,
95
viewElementSourceFunction,
@@ -167,9 +164,6 @@ export default function DevTools({
164
</ViewElementSourceContext.Provider>
165
</SettingsContextController>
166
{warnIfLegacyBackendDetected && <WarnIfLegacyBackendDetected />}
170
- {showWelcomeToTheNewDevToolsDialog && (
171
- <ShowWelcomeToTheNewDevToolsDialog />
172
- )}
167
</ModalDialogContextController>
168
</StoreContext.Provider>
169
</BridgeContext.Provider>
packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.css
deleted
-26
@@ -1,26 +0,0 @@
1
-.Row {
2
- display: flex;
3
- flex-direction: row;
4
- align-items: center;
5
-}
6
-
7
-.Column {
8
- display: flex;
9
- flex-direction: column;
10
- align-items: center;
11
-}
12
-
13
-.Logo {
14
- height: 4rem;
15
- width: 4rem;
16
- margin: 1rem;
17
-}
18
-
19
-.Title {
20
- font-size: var(--font-size-sans-large);
21
- margin-bottom: 0.5rem;
22
-}
23
-
24
-.ReleaseNotesLink {
25
- color: var(--color-button-active);
26
-}
packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.js
deleted
-73
@@ -1,73 +0,0 @@
1
-/**
2
- * Copyright (c) Facebook, Inc. and its affiliates.
3
- *
4
- * This source code is licensed under the MIT license found in the
5
- * LICENSE file in the root directory of this source tree.
6
- *
7
- * @flow
8
- */
9
-
10
-import React, {Fragment, useContext, useEffect} from 'react';
11
-import {unstable_batchedUpdates as batchedUpdates} from 'react-dom';
12
-import {useLocalStorage} from './hooks';
13
-import {ModalDialogContext} from './ModalDialog';
14
-import ReactLogo from './ReactLogo';
15
-import {CHANGE_LOG_URL} from 'react-devtools-shared/src/constants';
16
-
17
-import styles from './ShowWelcomeToTheNewDevToolsDialog.css';
18
-
19
-const LOCAL_STORAGE_KEY =
20
- 'React::DevTools::hasShownWelcomeToTheNewDevToolsDialog';
21
-
22
-export default function ShowWelcomeToTheNewDevToolsDialog(_: {||}) {
23
- const {dispatch} = useContext(ModalDialogContext);
24
- const [
25
- hasShownWelcomeToTheNewDevToolsDialog,
26
- setHasShownWelcomeToTheNewDevToolsDialog,
27
- ] = useLocalStorage<boolean>(LOCAL_STORAGE_KEY, false);
28
-
29
- useEffect(
30
- () => {
31
- if (!hasShownWelcomeToTheNewDevToolsDialog) {
32
- batchedUpdates(() => {
33
- setHasShownWelcomeToTheNewDevToolsDialog(true);
34
- dispatch({
35
- canBeDismissed: true,
36
- type: 'SHOW',
37
- content: <DialogContent />,
38
- });
39
- });
40
- }
41
- },
42
- [
43
- dispatch,
44
- hasShownWelcomeToTheNewDevToolsDialog,
45
- setHasShownWelcomeToTheNewDevToolsDialog,
46
- ],
47
- );
48
-
49
- return null;
50
-}
51
-
52
-function DialogContent(_: {||}) {
53
- return (
54
- <Fragment>
55
- <div className={styles.Row}>
56
- <ReactLogo className={styles.Logo} />
57
- <div>
58
- <div className={styles.Title}>Welcome to the new React DevTools!</div>
59
- <div>
60
- <a
61
- className={styles.ReleaseNotesLink}
62
- target="_blank"
63
- rel="noopener noreferrer"
64
- href={CHANGE_LOG_URL}>
65
- Learn more
66
- </a>{' '}
67
- about changes in this version.
68
- </div>
69
- </div>
70
- </div>
71
- </Fragment>
72
- );
73
-}
packages/react-devtools-shell/src/devtools.js
-1
@@ -56,7 +56,6 @@ inject('dist/app.js', () => {
56
createElement(DevTools, {
57
browserTheme: 'light',
58
showTabBar: true,
59
- showWelcomeToTheNewDevToolsDialog: true,
59
warnIfLegacyBackendDetected: true,
60
}),
61
);