Re-enable shorthand CSS property collision warning (#18002)
Originally added in https://github.com/facebook/react/pull/14181; disabled in https://github.com/facebook/react/pull/14245. Intention was to enable it in React 16.7 but we forgot.
Sophie Alpert committed
Feb 10, 2020 at 03:42 UTC
4f71f25a34db0caa1c9c0b75f1f453f948272e65
8 files changed
+7
-10
packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js
renamed
-3
@@ -10,14 +10,11 @@
10
'use strict';
11
12
describe('ReactDOMShorthandCSSPropertyCollision', () => {
13
- let ReactFeatureFlags;
13
let React;
14
let ReactDOM;
15
16
beforeEach(() => {
17
jest.resetModules();
19
- ReactFeatureFlags = require('shared/ReactFeatureFlags');
20
- ReactFeatureFlags.warnAboutShorthandPropertyCollision = true;
18
React = require('react');
19
ReactDOM = require('react-dom');
20
});
packages/shared/ReactFeatureFlags.js
+1
-1
@@ -48,7 +48,7 @@ export const disableJavaScriptURLs = false;
48
// Control this behavior with a flag to support 16.6 minor releases in the meanwhile.
49
export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;
50
51
-export const warnAboutShorthandPropertyCollision = false;
51
+export const warnAboutShorthandPropertyCollision = true;
52
53
// Experimental React Flare event system and event components support.
54
export const enableDeprecatedFlareAPI = false;
packages/shared/forks/ReactFeatureFlags.native-fb.js
+1
-1
@@ -25,7 +25,7 @@ export const enableSuspenseServerRenderer = false;
25
export const enableSelectiveHydration = false;
26
export const enableChunksAPI = false;
27
export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;
28
-export const warnAboutShorthandPropertyCollision = false;
28
+export const warnAboutShorthandPropertyCollision = true;
29
export const enableSchedulerDebugging = false;
30
export const debugRenderPhaseSideEffectsForStrictMode = true;
31
export const disableJavaScriptURLs = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
+1
-1
@@ -24,7 +24,7 @@ export const enableChunksAPI = false;
24
export const disableJavaScriptURLs = false;
25
export const disableInputAttributeSyncing = false;
26
export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;
27
-export const warnAboutShorthandPropertyCollision = false;
27
+export const warnAboutShorthandPropertyCollision = true;
28
export const enableSchedulerDebugging = false;
29
export const enableDeprecatedFlareAPI = false;
30
export const enableFundamentalAPI = false;
packages/shared/forks/ReactFeatureFlags.persistent.js
+1
-1
@@ -24,7 +24,7 @@ export const enableChunksAPI = false;
24
export const disableJavaScriptURLs = false;
25
export const disableInputAttributeSyncing = false;
26
export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;
27
-export const warnAboutShorthandPropertyCollision = false;
27
+export const warnAboutShorthandPropertyCollision = true;
28
export const enableSchedulerDebugging = false;
29
export const enableDeprecatedFlareAPI = false;
30
export const enableFundamentalAPI = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
+1
-1
@@ -24,7 +24,7 @@ export const enableChunksAPI = false;
24
export const disableJavaScriptURLs = false;
25
export const disableInputAttributeSyncing = false;
26
export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;
27
-export const warnAboutShorthandPropertyCollision = false;
27
+export const warnAboutShorthandPropertyCollision = true;
28
export const enableSchedulerDebugging = false;
29
export const enableDeprecatedFlareAPI = false;
30
export const enableFundamentalAPI = false;
packages/shared/forks/ReactFeatureFlags.testing.js
+1
-1
@@ -24,7 +24,7 @@ export const enableChunksAPI = false;
24
export const disableJavaScriptURLs = false;
25
export const disableInputAttributeSyncing = false;
26
export const exposeConcurrentModeAPIs = __EXPERIMENTAL__;
27
-export const warnAboutShorthandPropertyCollision = false;
27
+export const warnAboutShorthandPropertyCollision = true;
28
export const enableSchedulerDebugging = false;
29
export const enableDeprecatedFlareAPI = false;
30
export const enableFundamentalAPI = false;
packages/shared/forks/ReactFeatureFlags.www.js
+1
-1
@@ -16,6 +16,7 @@ export const {
16
disableInputAttributeSyncing,
17
enableTrustedTypesIntegration,
18
deferPassiveEffectCleanupDuringUnmount,
19
+ warnAboutShorthandPropertyCollision,
20
} = require('ReactFeatureFlags');
21
22
// In www, we have experimental support for gathering data
@@ -32,7 +33,6 @@ export const enableSchedulerDebugging = true;
33
34
export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
35
export const warnAboutDeprecatedLifecycles = true;
35
-export const warnAboutShorthandPropertyCollision = false;
36
export const disableLegacyContext = false;
37
export const warnAboutStringRefs = false;
38
export const warnAboutDefaultPropsOnFunctionComponents = false;