Update release manager with latest change
Dan Abramov committed
Apr 5, 2017 at 17:16 UTC
4fa8122d5d7b0eb60d9bf2aa5e09e4cf4a6a20bf
1 file changed
+19
-18
scripts/release-manager/Readme.md
+19
-18
@@ -250,36 +250,37 @@ git clone https://github.com/reactjs/react-bower.git ../react-bower
250
251
### Build It!
252
253
-The next step depends on the type of release you want to cut.
253
255
-For a **stable** release, run in the working copy:
256
-
257
-```
258
-./node_modules/.bin/grunt release
259
-```
260
-
261
-This will create the build products in the working copy. You won’t see changes in git because the `build` folder is ignored. It will also create a commit and a tag in the `../react-bower` folder. I recommend checking `git log` and running `git show <put last commit hash here>` to verify the changes roughly correspond to what you expect.
262
-
263
-For a **pre-release**, run this instead:
254
+Run in the working copy:
255
256
```
257
npm run build
258
```
259
260
+This will create the build products in the working copy. You won’t see changes in git because the `build` folder is ignored.
261
+
262
### Verify the Build Works
263
271
-At the very least, open `fixtures/packaging/index.html` in the browser. You should see a “Hello, World!” fading in on each iframe, and the console should have no errors.
264
+At the very least, open `fixtures/packaging/babel-standalone/dev.html` in the browser. You should see a “Hello, World!” there, and the console should have no errors.
265
273
-If you changed anything related to how packages are created, I recommend following the instructions in `fixtures/packaging/README.md` and verifying that each of those manual tests works. You can skip the “build React” step in it but still need to build the fixtures.
266
+If you changed anything related to how packages are created, I recommend following the instructions in `fixtures/packaging/README.md` to verify all fixtures still work. You can skip the “build React” step in it but still need to build the fixtures. In short, run `node build-all.js` in `fixtures` folder and follow the instructions it prints.
267
268
They are manual tests, so the CI wouldn’t have caught errors in them.
269
277
-### Update the Docs
270
+### Update Bower and Docs
271
272
**This step is only necessary for a stable release.**
273
If you’re just cutting an alpha, you should skip it.
274
282
-You will see that `docs/js/react-dom.js` and `docs/js/react.js` have changed. This is because the docs are now using a newer version of React. In addition to those changes, bump the version inside `docs/_config.yml`:
275
+**TODO: We used to have a `grunt release` command that does a few extra things but it was deleted when we moved build process to Rollup. We need to decide if we care about Bower or not, and if we do, either add a similar script back, or write up commands to do it by hand.**
276
+
277
+[Here's what the script used to do:](https://github.com/facebook/react/blob/50b3cab3ec7565085da21106791dbaa6fe22d862/grunt/tasks/release.js)
278
+
279
+* Copy UMD bundles to `../react-bower`.
280
+* Commit and tag them in `react-bower` (but not push yet).
281
+* Copy them to `docs/js/` (note: we changed their filenames so might need to change docs too).
282
+
283
+In addition to those changes, bump the version inside `docs/_config.yml`:
284
285
```diff
286
- react_version: 15.4.0
@@ -386,10 +387,10 @@ Copy your new release notes from `CHANGELOG.md` and [create a new Release](https
387
388
Finally, attach these files to the release:
389
389
-* `build/dist/react.dev.js`
390
-* `build/dist/react.min.prod.js`
391
-* `build/dist/react-dom.dev.js`
392
-* `build/dist/react-dom.prod.min.js`
390
+* `build/dist/react.development.js`
391
+* `build/dist/react.production.min.js`
392
+* `build/dist/react-dom.development.js`
393
+* `build/dist/react-dom.production.min.js`
394
395
### Force-Updating the Website
396