Remove unnecessary topLevelTypes indirection
topLevelTypes is a key mirror, so dependency and topLevelType are always the same here.
Ben Alpert committed
May 26, 2014 at 23:11 UTC
52127dd7cf10eb75629ef595c00425ebf9f7dd82
1 file changed
+8
-10
src/browser/ReactBrowserEventEmitter.js
+8
-10
@@ -226,12 +226,10 @@ var ReactBrowserEventEmitter = merge(ReactEventEmitterMixin, {
226
for (var i = 0, l = dependencies.length; i < l; i++) {
227
var dependency = dependencies[i];
228
if (!(
229
- isListening.hasOwnProperty(dependency) &&
230
- isListening[dependency]
231
- )) {
232
- var topLevelType = topLevelTypes[dependency];
233
-
234
- if (topLevelType === topLevelTypes.topWheel) {
229
+ isListening.hasOwnProperty(dependency) &&
230
+ isListening[dependency]
231
+ )) {
232
+ if (dependency === topLevelTypes.topWheel) {
233
if (isEventSupported('wheel')) {
234
ReactBrowserEventEmitter.ReactEventListener.trapBubbledEvent(
235
topLevelTypes.topWheel,
@@ -253,7 +251,7 @@ var ReactBrowserEventEmitter = merge(ReactEventEmitterMixin, {
251
mountAt
252
);
253
}
256
- } else if (topLevelType === topLevelTypes.topScroll) {
254
+ } else if (dependency === topLevelTypes.topScroll) {
255
256
if (isEventSupported('scroll', true)) {
257
ReactBrowserEventEmitter.ReactEventListener.trapCapturedEvent(
@@ -268,8 +266,8 @@ var ReactBrowserEventEmitter = merge(ReactEventEmitterMixin, {
266
ReactBrowserEventEmitter.ReactEventListener.WINDOW_HANDLE
267
);
268
}
271
- } else if (topLevelType === topLevelTypes.topFocus ||
272
- topLevelType === topLevelTypes.topBlur) {
269
+ } else if (dependency === topLevelTypes.topFocus ||
270
+ dependency === topLevelTypes.topBlur) {
271
272
if (isEventSupported('focus', true)) {
273
ReactBrowserEventEmitter.ReactEventListener.trapCapturedEvent(
@@ -302,7 +300,7 @@ var ReactBrowserEventEmitter = merge(ReactEventEmitterMixin, {
300
isListening[topLevelTypes.topFocus] = true;
301
} else if (topEventMapping.hasOwnProperty(dependency)) {
302
ReactBrowserEventEmitter.ReactEventListener.trapBubbledEvent(
305
- topLevelType,
303
+ dependency,
304
topEventMapping[dependency],
305
mountAt
306
);