Drop ReactDOM from internal DOM extensions
These used to be exposed as strings on the legacy factories but are now gone.
Sebastian Markbage committed
Oct 17, 2014 at 22:42 UTC
531c2bc4c9a25f98c794a2c732a1232975ab9bbb
7 files changed
+7
-21
src/browser/ui/dom/components/ReactDOMButton.js
+1
-3
@@ -15,12 +15,10 @@ var AutoFocusMixin = require('AutoFocusMixin');
15
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
16
var ReactClass = require('ReactClass');
17
var ReactElement = require('ReactElement');
18
-var ReactDOM = require('ReactDOM');
18
19
var keyMirror = require('keyMirror');
20
22
-// Store a reference to the <button> `ReactDOMComponent`. TODO: use string
23
-var button = ReactElement.createFactory(ReactDOM.button.type);
21
+var button = ReactElement.createFactory('button');
22
23
var mouseListenerNames = keyMirror({
24
onClick: true,
src/browser/ui/dom/components/ReactDOMForm.js
+1
-3
@@ -16,10 +16,8 @@ var LocalEventTrapMixin = require('LocalEventTrapMixin');
16
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
17
var ReactClass = require('ReactClass');
18
var ReactElement = require('ReactElement');
19
-var ReactDOM = require('ReactDOM');
19
21
-// Store a reference to the <form> `ReactDOMComponent`. TODO: use string
22
-var form = ReactElement.createFactory(ReactDOM.form.type);
20
+var form = ReactElement.createFactory('form');
21
22
/**
23
* Since onSubmit doesn't bubble OR capture on the top level in IE8, we need
src/browser/ui/dom/components/ReactDOMImg.js
+1
-3
@@ -16,10 +16,8 @@ var LocalEventTrapMixin = require('LocalEventTrapMixin');
16
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
17
var ReactClass = require('ReactClass');
18
var ReactElement = require('ReactElement');
19
-var ReactDOM = require('ReactDOM');
19
21
-// Store a reference to the <img> `ReactDOMComponent`. TODO: use string
22
-var img = ReactElement.createFactory(ReactDOM.img.type);
20
+var img = ReactElement.createFactory('img');
21
22
/**
23
* Since onLoad doesn't bubble OR capture on the top level in IE8, we need to
src/browser/ui/dom/components/ReactDOMInput.js
+1
-3
@@ -17,15 +17,13 @@ var LinkedValueUtils = require('LinkedValueUtils');
17
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
18
var ReactClass = require('ReactClass');
19
var ReactElement = require('ReactElement');
20
-var ReactDOM = require('ReactDOM');
20
var ReactMount = require('ReactMount');
21
var ReactUpdates = require('ReactUpdates');
22
23
var assign = require('Object.assign');
24
var invariant = require('invariant');
25
27
-// Store a reference to the <input> `ReactDOMComponent`. TODO: use string
28
-var input = ReactElement.createFactory(ReactDOM.input.type);
26
+var input = ReactElement.createFactory('input');
27
28
var instancesByReactID = {};
29
src/browser/ui/dom/components/ReactDOMOption.js
+1
-3
@@ -14,12 +14,10 @@
14
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
15
var ReactClass = require('ReactClass');
16
var ReactElement = require('ReactElement');
17
-var ReactDOM = require('ReactDOM');
17
18
var warning = require('warning');
19
21
-// Store a reference to the <option> `ReactDOMComponent`. TODO: use string
22
-var option = ReactElement.createFactory(ReactDOM.option.type);
20
+var option = ReactElement.createFactory('option');
21
22
/**
23
* Implements an <option> native component that warns when `selected` is set.
src/browser/ui/dom/components/ReactDOMSelect.js
+1
-3
@@ -16,13 +16,11 @@ var LinkedValueUtils = require('LinkedValueUtils');
16
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
17
var ReactClass = require('ReactClass');
18
var ReactElement = require('ReactElement');
19
-var ReactDOM = require('ReactDOM');
19
var ReactUpdates = require('ReactUpdates');
20
21
var assign = require('Object.assign');
22
24
-// Store a reference to the <select> `ReactDOMComponent`. TODO: use string
25
-var select = ReactElement.createFactory(ReactDOM.select.type);
23
+var select = ReactElement.createFactory('select');
24
25
function updateWithPendingValueIfMounted() {
26
/*jshint validthis:true */
src/browser/ui/dom/components/ReactDOMTextarea.js
+1
-3
@@ -17,7 +17,6 @@ var LinkedValueUtils = require('LinkedValueUtils');
17
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
18
var ReactClass = require('ReactClass');
19
var ReactElement = require('ReactElement');
20
-var ReactDOM = require('ReactDOM');
20
var ReactUpdates = require('ReactUpdates');
21
22
var assign = require('Object.assign');
@@ -25,8 +24,7 @@ var invariant = require('invariant');
24
25
var warning = require('warning');
26
28
-// Store a reference to the <textarea> `ReactDOMComponent`. TODO: use string
29
-var textarea = ReactElement.createFactory(ReactDOM.textarea.type);
27
+var textarea = ReactElement.createFactory('textarea');
28
29
function forceUpdateIfMounted() {
30
/*jshint validthis:true */