@samitouri / QOS-React-2 / commits / 57bf275fbd

[devtools] Add support for React Scope symbol/number (#16893)

Dominic Gannaway committed Sep 25, 2019 at 19:03 UTC 57bf275fbd89afc9afb84cefb950eb74c3573ea7
1 file changed +9 -12
packages/react-devtools-shared/src/backend/renderer.js
+9 -12
@@ -82,12 +82,6 @@ type ReactSymbolsType = {
82 CONTEXT_CONSUMER_SYMBOL_STRING: string,
83 CONTEXT_PROVIDER_NUMBER: number,
84 CONTEXT_PROVIDER_SYMBOL_STRING: string,
85 - EVENT_COMPONENT_NUMBER: number,
86 - EVENT_COMPONENT_STRING: string,
87 - EVENT_TARGET_NUMBER: number,
88 - EVENT_TARGET_STRING: string,
89 - EVENT_TARGET_TOUCH_HIT_NUMBER: number,
90 - EVENT_TARGET_TOUCH_HIT_STRING: string,
85 FORWARD_REF_NUMBER: number,
86 FORWARD_REF_SYMBOL_STRING: string,
87 MEMO_NUMBER: number,
@@ -99,6 +93,8 @@ type ReactSymbolsType = {
93 SUSPENSE_NUMBER: number,
94 SUSPENSE_SYMBOL_STRING: string,
95 DEPRECATED_PLACEHOLDER_SYMBOL_STRING: string,
96 + SCOPE_NUMBER: number,
97 + SCOPE_SYMBOL_STRING: string,
98 };
99
100 type ReactPriorityLevelsType = {|
@@ -165,12 +161,6 @@ export function getInternalReactConstants(
161 CONTEXT_CONSUMER_SYMBOL_STRING: 'Symbol(react.context)',
162 CONTEXT_PROVIDER_NUMBER: 0xeacd,
163 CONTEXT_PROVIDER_SYMBOL_STRING: 'Symbol(react.provider)',
168 - EVENT_COMPONENT_NUMBER: 0xead5,
169 - EVENT_COMPONENT_STRING: 'Symbol(react.event_component)',
170 - EVENT_TARGET_NUMBER: 0xead6,
171 - EVENT_TARGET_STRING: 'Symbol(react.event_target)',
172 - EVENT_TARGET_TOUCH_HIT_NUMBER: 0xead7,
173 - EVENT_TARGET_TOUCH_HIT_STRING: 'Symbol(react.event_target.touch_hit)',
164 FORWARD_REF_NUMBER: 0xead0,
165 FORWARD_REF_SYMBOL_STRING: 'Symbol(react.forward_ref)',
166 MEMO_NUMBER: 0xead3,
@@ -182,6 +172,8 @@ export function getInternalReactConstants(
172 SUSPENSE_NUMBER: 0xead1,
173 SUSPENSE_SYMBOL_STRING: 'Symbol(react.suspense)',
174 DEPRECATED_PLACEHOLDER_SYMBOL_STRING: 'Symbol(react.placeholder)',
175 + SCOPE_NUMBER: 0xead7,
176 + SCOPE_SYMBOL_STRING: 'Symbol(react.scope)',
177 };
178
179 const ReactTypeOfSideEffect: ReactTypeOfSideEffectType = {
@@ -331,6 +323,8 @@ export function getInternalReactConstants(
323 DEPRECATED_PLACEHOLDER_SYMBOL_STRING,
324 PROFILER_NUMBER,
325 PROFILER_SYMBOL_STRING,
326 + SCOPE_NUMBER,
327 + SCOPE_SYMBOL_STRING,
328 } = ReactSymbols;
329
330 // NOTICE Keep in sync with shouldFilterFiber() and other get*ForFiber methods
@@ -410,6 +404,9 @@ export function getInternalReactConstants(
404 case PROFILER_NUMBER:
405 case PROFILER_SYMBOL_STRING:
406 return `Profiler(${fiber.memoizedProps.id})`;
407 + case SCOPE_NUMBER:
408 + case SCOPE_SYMBOL_STRING:
409 + return 'Scope';
410 default:
411 // Unknown element type.
412 // This may mean a new element type that has not yet been added to DevTools.