Fix for the issue #5189
Fix for lint issues Added the test cases for the issue 5189 Removing empty space Removing the Eventplugin instrumentation code Removing unwanted white space
Ants committed
Oct 19, 2015 at 18:02 UTC
59db07c4f984f747c47e67219781577d30b21762
3 files changed
+24
-15
src/renderers/shared/event/EventPluginHub.js
-6
@@ -14,7 +14,6 @@
14
var EventPluginRegistry = require('EventPluginRegistry');
15
var EventPluginUtils = require('EventPluginUtils');
16
var ReactErrorUtils = require('ReactErrorUtils');
17
-var ReactPerf = require('ReactPerf');
17
18
var accumulateInto = require('accumulateInto');
19
var forEachAccumulated = require('forEachAccumulated');
@@ -308,9 +307,4 @@ var EventPluginHub = {
307
308
};
309
311
-ReactPerf.measureMethods(EventPluginHub, 'EventPluginHub', {
312
- putListener: 'putListener',
313
- deleteListener: 'deleteListener',
314
-});
315
-
310
module.exports = EventPluginHub;
src/test/ReactDefaultPerf.js
-1
@@ -165,7 +165,6 @@ var ReactDefaultPerf = {
165
].totalTime = performanceNow() - start;
166
return rv;
167
} else if (fnName === '_mountImageIntoNode' ||
168
- moduleName === 'EventPluginHub' ||
168
moduleName === 'ReactDOMIDOperations' ||
169
moduleName === 'CSSPropertyOperations' ||
170
moduleName === 'DOMChildrenOperations' ||
src/test/__tests__/ReactDefaultPerf-test.js
+24
-8
@@ -16,6 +16,7 @@ describe('ReactDefaultPerf', function() {
16
var ReactDOM;
17
var ReactDefaultPerf;
18
var ReactTestUtils;
19
+ var ReactDefaultPerfAnalysis;
20
21
var App;
22
var Box;
@@ -31,6 +32,7 @@ describe('ReactDefaultPerf', function() {
32
ReactDOM = require('ReactDOM');
33
ReactDefaultPerf = require('ReactDefaultPerf');
34
ReactTestUtils = require('ReactTestUtils');
35
+ ReactDefaultPerfAnalysis = require('ReactDefaultPerfAnalysis');
36
37
App = React.createClass({
38
render: function() {
@@ -142,14 +144,6 @@ describe('ReactDefaultPerf', function() {
144
});
145
});
146
145
- it('should not count listener update as waste', function() {
146
- var container = document.createElement('div');
147
- ReactDOM.render(<Div onClick={function() {}}>hey</Div>, container);
148
- expectNoWaste(() => {
149
- ReactDOM.render(<Div onClick={function() {}}>hey</Div>, container);
150
- });
151
- });
152
-
147
it('should not count property removal as waste', function() {
148
var container = document.createElement('div');
149
ReactDOM.render(<Div className="yellow">hey</Div>, container);
@@ -188,4 +182,26 @@ describe('ReactDefaultPerf', function() {
182
});
183
});
184
185
+ it('putListener should not be instrumented', function() {
186
+ var container = document.createElement('div');
187
+ ReactDOM.render(<Div onClick={function() {}}>hey</Div>, container);
188
+ var measurements = measure(() => {
189
+ ReactDOM.render(<Div onClick={function() {}}>hey</Div>, container);
190
+ });
191
+
192
+ var summary = ReactDefaultPerfAnalysis.getDOMSummary(measurements);
193
+ expect(summary).toEqual([]);
194
+ });
195
+
196
+ it('deleteListener should not be instrumented', function() {
197
+ var container = document.createElement('div');
198
+ ReactDOM.render(<Div onClick={function() {}}>hey</Div>, container);
199
+ var measurements = measure(() => {
200
+ ReactDOM.render(<Div>hey</Div>, container);
201
+ });
202
+
203
+ var summary = ReactDefaultPerfAnalysis.getDOMSummary(measurements);
204
+ expect(summary).toEqual([]);
205
+ });
206
+
207
});