Make sure react-dom-server is shipped in release process
Also removed some duplicated code to simplify a bit
Paul O’Shannessy committed
Nov 18, 2015 at 13:05 UTC
5a80b20017226d8e9e431a03a1f3fa3c6933853b
5 files changed
+18
-40
Gruntfile.js
-2
@@ -110,7 +110,6 @@ module.exports = function(grunt) {
110
'npm-react:release',
111
]);
112
grunt.registerTask('build:react-dom', require('./grunt/tasks/react-dom'));
113
- grunt.registerTask('build:react-dom-server', require('./grunt/tasks/react-dom-server'));
113
114
grunt.registerTask('test', ['jest']);
115
grunt.registerTask('npm:test', ['build', 'npm:pack']);
@@ -128,7 +127,6 @@ module.exports = function(grunt) {
127
'browserify:min',
128
'browserify:addonsMin',
129
'build:react-dom',
131
- 'build:react-dom-server',
130
'npm-react:release',
131
'npm-react:pack',
132
'npm-react-dom:release',
grunt/tasks/npm-react-dom.js
+2
@@ -9,6 +9,8 @@ var dist = dest + 'dist/';
9
var distFiles = [
10
'react-dom.js',
11
'react-dom.min.js',
12
+ 'react-dom-server.js',
13
+ 'react-dom-server.min.js',
14
];
15
16
function buildRelease() {
grunt/tasks/react-dom-server.js
deleted
-27
@@ -1,27 +0,0 @@
1
-'use strict';
2
-
3
-var grunt = require('grunt');
4
-var UglifyJS = require('uglify-js');
5
-
6
-var LICENSE_TEMPLATE =
7
- grunt.file.read('./grunt/data/header-template-extended.txt');
8
-
9
-module.exports = function() {
10
- var templateData = {
11
- package: 'ReactDOMServer',
12
- version: grunt.config.data.pkg.version,
13
- };
14
- var header = grunt.template.process(
15
- LICENSE_TEMPLATE,
16
- {data: templateData}
17
- );
18
- var src = grunt.file.read('vendor/react-dom-server.js');
19
- grunt.file.write(
20
- 'build/react-dom-server.js',
21
- header + src
22
- );
23
- grunt.file.write(
24
- 'build/react-dom-server.min.js',
25
- header + UglifyJS.minify(src, {fromString: true}).code
26
- );
27
-};
grunt/tasks/react-dom.js
+14
-11
@@ -6,22 +6,25 @@ var UglifyJS = require('uglify-js');
6
var LICENSE_TEMPLATE =
7
grunt.file.read('./grunt/data/header-template-extended.txt');
8
9
-module.exports = function() {
9
+function build(name, filename) {
10
+ var srcFile = `vendor/${filename}.js`;
11
+ var destFile = `build/${filename}.js`;
12
+ var destFileMin = `build/${filename}.min.js`;
13
var templateData = {
11
- package: 'ReactDOM',
14
+ package: name,
15
version: grunt.config.data.pkg.version,
16
};
17
var header = grunt.template.process(
18
LICENSE_TEMPLATE,
19
{data: templateData}
20
);
18
- var src = grunt.file.read('vendor/react-dom.js');
19
- grunt.file.write(
20
- 'build/react-dom.js',
21
- header + src
22
- );
23
- grunt.file.write(
24
- 'build/react-dom.min.js',
25
- header + UglifyJS.minify(src, {fromString: true}).code
26
- );
21
+ var src = grunt.file.read(srcFile);
22
+ var srcMin = UglifyJS.minify(src, {fromString: true}).code;
23
+ grunt.file.write(destFile, header + src);
24
+ grunt.file.write(destFileMin, header + srcMin);
25
+}
26
+
27
+module.exports = function() {
28
+ build('ReactDOM', 'react-dom');
29
+ build('ReactDOMServer', 'react-dom-server');
30
};
grunt/tasks/release.js
+2
@@ -11,6 +11,8 @@ var BOWER_FILES = [
11
'react-with-addons.min.js',
12
'react-dom.js',
13
'react-dom.min.js',
14
+ 'react-dom-server.js',
15
+ 'react-dom-server.min.js',
16
];
17
18
var EXAMPLES_PATH = 'examples/';