@samitouri / QOS-React-2 / commits / 60cfeeebe3

[DevTools] Replace deprecated `new-window` with `webContents.setWindowOpenHandler()` (#26559)

## Summary The electron package was recently upgraded from ^11.1.0 to ^23.1.2 (#26337). However, the WebContents `new-window` event – that is used in the react-devtools project – was deprecated in [v12.0.0](https://releases.electronjs.org/release/v12.0.0) and removed in [v22.2.0](https://releases.electronjs.org/release/v22.2.0). The event was replaced by `webContents.setWindowOpenHandler()`. This PR replaces the `new-window` event with `webContents.setWindowOpenHandler()`. ## How did you test this change? I created a simple electron application with similar functionality: ``` const { app, BrowserWindow, shell } = require('electron') const createWindow = () => { const mainWindow = new BrowserWindow({ width: 800, height: 600 }) mainWindow.webContents.setWindowOpenHandler(({ url }) => { shell.openExternal(url) return { action: 'deny' } }) mainWindow.loadFile('index.html') } app.whenReady().then(() => { createWindow() }) ``` --------- Co-authored-by: root <root@DESKTOP-KCGHLB8.localdomain>

Willie-Boy committed Apr 6, 2023 at 17:02 UTC 60cfeeebe3902f4f996973ce8189afcb7363a6be

1 file changed +4 -4

packages/react-devtools/app.js

+4 -4

@@ -5,7 +5,7 @@

5 * LICENSE file in the root directory of this source tree.

6 */

8 -const {app, BrowserWindow} = require('electron'); // Module to create native browser window.

8 +const {app, BrowserWindow, shell} = require('electron'); // Module to create native browser window.

9 const {join} = require('path');

10 const os = require('os');

@@ -40,9 +40,9 @@ app.on('ready', function () {

40 }

42 // https://stackoverflow.com/questions/32402327/

43 - mainWindow.webContents.on('new-window', function (event, url) {

44 - event.preventDefault();

45 - require('electron').shell.openExternal(url);

43 + mainWindow.webContents.setWindowOpenHandler(({url}) => {

44 + shell.openExternal(url);

45 + return {action: 'deny'};

46 });

48 // and load the index.html of the app.