@samitouri / QOS-React-2 / commits / 64f50c667a

Remove disableHiddenPropDeprioritization flag (#18964)

This is rolled out to 100% public, so we can remove it.

Andrew Clark committed May 20, 2020 at 15:29 UTC 64f50c667a778c85dc8f1d56e26d881fada4c85a
10 files changed +3 -22
packages/react-dom/src/client/ReactDOMHostConfig.js
+3 -9
@@ -78,7 +78,6 @@ import {
78 enableModernEventSystem,
79 enableCreateEventHandleAPI,
80 enableScopeAPI,
81 - disableHiddenPropDeprioritization,
81 } from 'shared/ReactFeatureFlags';
82 import {HostComponent, HostText} from 'react-reconciler/src/ReactWorkTags';
83 import {TOP_BEFORE_BLUR, TOP_AFTER_BLUR} from '../events/DOMTopLevelEventTypes';
@@ -373,14 +372,9 @@ export function shouldSetTextContent(type: string, props: Props): boolean {
372 }
373
374 export function shouldDeprioritizeSubtree(type: string, props: Props): boolean {
376 - if (disableHiddenPropDeprioritization) {
377 - // This is obnoxiously specific so that nobody uses it, but we can still opt
378 - // in via an infra-level userspace abstraction.
379 - return props.hidden === 'unstable-do-not-use-legacy-hidden';
380 - } else {
381 - // Legacy behavior. Any truthy value works.
382 - return !!props.hidden;
383 - }
375 + // This is obnoxiously specific so that nobody uses it, but we can still opt
376 + // in via an infra-level userspace abstraction.
377 + return props.hidden === 'unstable-do-not-use-legacy-hidden';
378 }
379
380 export function createTextInstance(
packages/shared/ReactFeatureFlags.js
-3
@@ -138,6 +138,3 @@ export const enableLegacyFBSupport = false;
138 // expiration time is currently rendering. Remove this flag once we have
139 // migrated to the new behavior.
140 export const deferRenderPhaseUpdateToNextBatch = true;
141 -
142 -// Flag used by www build so we can log occurrences of legacy hidden API
143 -export const disableHiddenPropDeprioritization = true;
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -48,7 +48,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
48
49 export const enableNewReconciler = false;
50 export const deferRenderPhaseUpdateToNextBatch = true;
51 -export const disableHiddenPropDeprioritization = true;
51
52 // Flow magic to verify the exports of this file match the original version.
53 // eslint-disable-next-line no-unused-vars
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -47,7 +47,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
47
48 export const enableNewReconciler = false;
49 export const deferRenderPhaseUpdateToNextBatch = true;
50 -export const disableHiddenPropDeprioritization = true;
50
51 // Flow magic to verify the exports of this file match the original version.
52 // eslint-disable-next-line no-unused-vars
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -47,7 +47,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
47
48 export const enableNewReconciler = false;
49 export const deferRenderPhaseUpdateToNextBatch = true;
50 -export const disableHiddenPropDeprioritization = true;
50
51 // Flow magic to verify the exports of this file match the original version.
52 // eslint-disable-next-line no-unused-vars
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -47,7 +47,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
47
48 export const enableNewReconciler = false;
49 export const deferRenderPhaseUpdateToNextBatch = true;
50 -export const disableHiddenPropDeprioritization = true;
50
51 // Flow magic to verify the exports of this file match the original version.
52 // eslint-disable-next-line no-unused-vars
packages/shared/forks/ReactFeatureFlags.testing.js
-1
@@ -47,7 +47,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
47
48 export const enableNewReconciler = false;
49 export const deferRenderPhaseUpdateToNextBatch = true;
50 -export const disableHiddenPropDeprioritization = true;
50
51 // Flow magic to verify the exports of this file match the original version.
52 // eslint-disable-next-line no-unused-vars
packages/shared/forks/ReactFeatureFlags.testing.www.js
-1
@@ -47,7 +47,6 @@ export const enableFilterEmptyStringAttributesDOM = false;
47
48 export const enableNewReconciler = false;
49 export const deferRenderPhaseUpdateToNextBatch = true;
50 -export const disableHiddenPropDeprioritization = true;
50
51 // Flow magic to verify the exports of this file match the original version.
52 // eslint-disable-next-line no-unused-vars
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-3
@@ -21,9 +21,6 @@ export const enableModernEventSystem = __VARIANT__;
21 export const enableLegacyFBSupport = __VARIANT__;
22 export const enableDebugTracing = !__VARIANT__;
23
24 -// Temporary flag, in case we need to re-enable this feature.
25 -export const disableHiddenPropDeprioritization = __VARIANT__;
26 -
24 // This only has an effect in the new reconciler. But also, the new reconciler
25 // is only enabled when __VARIANT__ is true. So this is set to the opposite of
26 // __VARIANT__ so that it's `false` when running against the new reconciler.
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -27,7 +27,6 @@ export const {
27 enableLegacyFBSupport,
28 enableDebugTracing,
29 deferRenderPhaseUpdateToNextBatch,
30 - disableHiddenPropDeprioritization,
30 } = dynamicFeatureFlags;
31
32 // On WWW, __EXPERIMENTAL__ is used for a new modern build.