Start warning when calling a legacy factory
Let's start warning when a legacy factory is called as a plain function call.
Sebastian Markbage committed
Aug 19, 2014 at 23:16 UTC
68b7b8214530dd4cfcb810c46342e6d34200bbf4
1 file changed
+9
-2
src/core/ReactLegacyDescriptor.js
+9
-2
@@ -31,12 +31,19 @@ function warnForLegacyFactoryCall() {
31
return;
32
}
33
var owner = ReactCurrentOwner.current;
34
- var name = owner && owner.constructor ? owner.constructor.displayName : 'N/A';
34
+ var name = owner && owner.constructor ? owner.constructor.displayName : '';
35
+ if (!name) {
36
+ name = 'Something';
37
+ }
38
if (legacyFactoryLogs.hasOwnProperty(name)) {
39
return;
40
}
41
legacyFactoryLogs[name] = true;
39
- // TODO: Warn for this.
42
+ warning(
43
+ false,
44
+ name + ' is calling a React component directly. ' +
45
+ 'Use a factory or JSX instead. See: http://fb.me/react-legacyfactory'
46
+ );
47
monitorCodeUse('react_legacy_factory_call', { name: name });
48
}
49