Remove unstable_ prefix in various internal uses (#17146)
* Rename unstable_createRoot in DevTools * Rename createSyncRoot in warning
Sebastian Markbåge committed
Oct 18, 2019 at 17:18 UTC
68fb58029d818979804677a4d1063eb71f2934f4
7 files changed
+11
-11
packages/react-devtools-core/src/standalone.js
+1
-1
@@ -12,7 +12,7 @@ import {
12
// $FlowFixMe Flow does not yet know about flushSync()
13
flushSync,
14
// $FlowFixMe Flow does not yet know about createRoot()
15
- unstable_createRoot as createRoot,
15
+ createRoot,
16
} from 'react-dom';
17
import Bridge from 'react-devtools-shared/src/bridge';
18
import Store from 'react-devtools-shared/src/devtools/store';
packages/react-devtools-extensions/src/main.js
+1
-1
@@ -1,7 +1,7 @@
1
/* global chrome */
2
3
import {createElement} from 'react';
4
-import {unstable_createRoot as createRoot, flushSync} from 'react-dom';
4
+import {createRoot, flushSync} from 'react-dom';
5
import Bridge from 'react-devtools-shared/src/bridge';
6
import Store from 'react-devtools-shared/src/devtools/store';
7
import {
packages/react-devtools-inline/README.md
+5
-5
@@ -60,7 +60,7 @@ const contentWindow = iframe.contentWindow;
60
const DevTools = initialize(contentWindow);
61
```
62
63
-<sup>3</sup> Because the DevTools interface makes use of several new React APIs (e.g. suspense, concurrent mode) it should be rendered using either `ReactDOM.unstable_createRoot` or `ReactDOM.unstable_createSyncRoot`. **It should not be rendered with `ReactDOM.render`.**
63
+<sup>3</sup> Because the DevTools interface makes use of several new React APIs (e.g. suspense, concurrent mode) it should be rendered using either `ReactDOM.createRoot` or `ReactDOM.createSyncRoot`. **It should not be rendered with `ReactDOM.render`.**
64
65
## Examples
66
@@ -92,8 +92,8 @@ initializeBackend(contentWindow);
92
const DevTools = initializeFrontend(contentWindow);
93
94
// <DevTools /> interface can be rendered in the parent window at any time now...
95
-// Be sure to use either ReactDOM.unstable_createRoot()
96
-// or ReactDOM.unstable_createSyncRoot() to render this component.
95
+// Be sure to use either ReactDOM.createRoot()
96
+// or ReactDOM.createSyncRoot() to render this component.
97
98
// Let the backend know the frontend is ready and listening.
99
activateBackend(contentWindow);
@@ -136,8 +136,8 @@ const { contentWindow } = iframe;
136
137
// Initialize DevTools UI to listen to the iframe.
138
// This returns a React component we can render anywhere in the main window.
139
-// Be sure to use either ReactDOM.unstable_createRoot()
140
-// or ReactDOM.unstable_createSyncRoot() to render this component.
139
+// Be sure to use either ReactDOM.createRoot()
140
+// or ReactDOM.createSyncRoot() to render this component.
141
const DevTools = initialize(contentWindow);
142
143
// Let the backend know to initialize itself.
packages/react-devtools-shell/src/app/index.js
+1
-1
@@ -5,7 +5,7 @@
5
import {createElement} from 'react';
6
import {
7
// $FlowFixMe Flow does not yet know about createRoot()
8
- unstable_createRoot as createRoot,
8
+ createRoot,
9
} from 'react-dom';
10
import DeeplyNestedComponents from './DeeplyNestedComponents';
11
import Iframe from './Iframe';
packages/react-devtools-shell/src/devtools.js
+1
-1
@@ -2,7 +2,7 @@
2
3
import {createElement} from 'react';
4
// $FlowFixMe Flow does not yet know about createRoot()
5
-import {unstable_createRoot as createRoot} from 'react-dom';
5
+import {createRoot} from 'react-dom';
6
import {
7
activate as activateBackend,
8
initialize as initializeBackend,
packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js
+1
-1
@@ -344,7 +344,7 @@ describe('ReactDOMServerPartialHydration', () => {
344
}).toWarnDev(
345
'Warning: Cannot hydrate Suspense in legacy mode. Switch from ' +
346
'ReactDOM.hydrate(element, container) to ' +
347
- 'ReactDOM.unstable_createSyncRoot(container, { hydrate: true })' +
347
+ 'ReactDOM.createSyncRoot(container, { hydrate: true })' +
348
'.render(element) or remove the Suspense components from the server ' +
349
'rendered components.' +
350
'\n in Suspense (at **)' +
packages/react-reconciler/src/ReactFiberBeginWork.js
+1
-1
@@ -1972,7 +1972,7 @@ function mountDehydratedSuspenseComponent(
1972
false,
1973
'Cannot hydrate Suspense in legacy mode. Switch from ' +
1974
'ReactDOM.hydrate(element, container) to ' +
1975
- 'ReactDOM.unstable_createSyncRoot(container, { hydrate: true })' +
1975
+ 'ReactDOM.createSyncRoot(container, { hydrate: true })' +
1976
'.render(element) or remove the Suspense components from ' +
1977
'the server rendered components.',
1978
);