Drop processAttributeNameAndPrefix and invalid attribute name escaping
syranide committed
Feb 3, 2015 at 16:46 UTC
6af987c524d3801efd2a330f4ab1265b81f7cff3
1 file changed
+4
-11
src/browser/ui/dom/DOMPropertyOperations.js
+4
-11
@@ -16,7 +16,6 @@ var DOMProperty = require('DOMProperty');
16
17
var escapeTextContentForBrowser = require('escapeTextContentForBrowser');
18
var quoteAttributeValueForBrowser = require('quoteAttributeValueForBrowser');
19
-var memoizeStringOnly = require('memoizeStringOnly');
19
var warning = require('warning');
20
21
function shouldIgnoreValue(name, value) {
@@ -27,10 +26,6 @@ function shouldIgnoreValue(name, value) {
26
(DOMProperty.hasOverloadedBooleanValue[name] && value === false);
27
}
28
30
-var processAttributeNameAndPrefix = memoizeStringOnly(function(name) {
31
- return escapeTextContentForBrowser(name) + '=';
32
-});
33
-
29
if (__DEV__) {
30
var reactProps = {
31
children: true,
@@ -82,7 +77,7 @@ var DOMPropertyOperations = {
77
* @return {string} Markup string.
78
*/
79
createMarkupForID: function(id) {
85
- return processAttributeNameAndPrefix(DOMProperty.ID_ATTRIBUTE_NAME) +
80
+ return DOMProperty.ID_ATTRIBUTE_NAME + '=' +
81
quoteAttributeValueForBrowser(id);
82
},
83
@@ -102,16 +97,14 @@ var DOMPropertyOperations = {
97
var attributeName = DOMProperty.getAttributeName[name];
98
if (DOMProperty.hasBooleanValue[name] ||
99
(DOMProperty.hasOverloadedBooleanValue[name] && value === true)) {
105
- return escapeTextContentForBrowser(attributeName);
100
+ return attributeName;
101
}
107
- return processAttributeNameAndPrefix(attributeName) +
108
- quoteAttributeValueForBrowser(value);
102
+ return attributeName + '=' + quoteAttributeValueForBrowser(value);
103
} else if (DOMProperty.isCustomAttribute(name)) {
104
if (value == null) {
105
return '';
106
}
113
- return processAttributeNameAndPrefix(name) +
114
- quoteAttributeValueForBrowser(value);
107
+ return name + '=' + quoteAttributeValueForBrowser(value);
108
} else if (__DEV__) {
109
warnUnknownProperty(name);
110
}