Remove FeatureFlags fork for `react-dom/unstable_testing` (#26383)
This doesn't need its own set of flags. We use things like `__PROFILE__` in the regular feature flags file to fork for the `react-dom/profiling` build so we can do the same here if needed but I don't think we actually need to fork this anywhere as far as I can tell.
Sebastian Markbåge committed
Mar 13, 2023 at 18:43 UTC
6bd53a5bdfe24d9a70819c4eba40b488e62900cd
3 files changed
-165
packages/shared/forks/ReactFeatureFlags.testing.js
deleted
-78
@@ -1,78 +0,0 @@
1
-/**
2
- * Copyright (c) Meta Platforms, Inc. and affiliates.
3
- *
4
- * This source code is licensed under the MIT license found in the
5
- * LICENSE file in the root directory of this source tree.
6
- *
7
- * @flow
8
- */
9
-
10
-import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
11
-import typeof * as ExportsType from './ReactFeatureFlags.testing';
12
-
13
-export const debugRenderPhaseSideEffectsForStrictMode = false;
14
-export const enableDebugTracing = false;
15
-export const enableSchedulingProfiler = __PROFILE__;
16
-export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
17
-export const enableProfilerTimer = __PROFILE__;
18
-export const enableProfilerCommitHooks = __PROFILE__;
19
-export const enableProfilerNestedUpdatePhase = __PROFILE__;
20
-export const enableProfilerNestedUpdateScheduledHook = false;
21
-export const enableUpdaterTracking = false;
22
-export const enableCache = __EXPERIMENTAL__;
23
-export const enableLegacyCache = __EXPERIMENTAL__;
24
-export const enableCacheElement = __EXPERIMENTAL__;
25
-export const enableFetchInstrumentation = __EXPERIMENTAL__;
26
-export const disableJavaScriptURLs = false;
27
-export const disableCommentsAsDOMContainers = true;
28
-export const disableInputAttributeSyncing = false;
29
-export const enableSchedulerDebugging = false;
30
-export const enableScopeAPI = false;
31
-export const enableCreateEventHandleAPI = false;
32
-export const enableSuspenseCallback = false;
33
-export const disableLegacyContext = false;
34
-export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
35
-export const enableTrustedTypesIntegration = false;
36
-export const disableTextareaChildren = false;
37
-export const disableModulePatternComponents = false;
38
-export const enableSuspenseAvoidThisFallback = false;
39
-export const enableSuspenseAvoidThisFallbackFizz = false;
40
-export const enableCPUSuspense = false;
41
-export const enableUseHook = true;
42
-export const enableUseMemoCacheHook = false;
43
-export const enableUseEffectEventHook = false;
44
-export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
45
- true;
46
-export const enableClientRenderFallbackOnTextMismatch = true;
47
-export const enableComponentStackLocations = true;
48
-export const enableLegacyFBSupport = false;
49
-export const enableFilterEmptyStringAttributesDOM = false;
50
-export const disableNativeComponentFrames = false;
51
-export const skipUnmountedBoundaries = false;
52
-export const enableGetInspectorDataForInstanceInProduction = false;
53
-export const deferRenderPhaseUpdateToNextBatch = false;
54
-
55
-export const createRootStrictEffectsByDefault = false;
56
-export const enableUseRefAccessWarning = false;
57
-
58
-export const disableSchedulerTimeoutInWorkLoop = false;
59
-export const enableLazyContextPropagation = false;
60
-export const enableLegacyHidden = false;
61
-export const enableUnifiedSyncLane = __EXPERIMENTAL__;
62
-export const allowConcurrentByDefault = false;
63
-export const enableCustomElementPropertySupport = false;
64
-
65
-export const consoleManagedByDevToolsDuringStrictMode = false;
66
-export const enableServerContext = true;
67
-export const enableUseMutableSource = false;
68
-
69
-export const enableTransitionTracing = false;
70
-
71
-export const enableFloat = true;
72
-export const enableHostSingletons = true;
73
-
74
-export const useModernStrictMode = false;
75
-export const enableFizzExternalRuntime = false;
76
-
77
-// Flow magic to verify the exports of this file match the original version.
78
-((((null: any): ExportsType): FeatureFlagsType): ExportsType);
packages/shared/forks/ReactFeatureFlags.testing.www.js
deleted
-79
@@ -1,79 +0,0 @@
1
-/**
2
- * Copyright (c) Meta Platforms, Inc. and affiliates.
3
- *
4
- * This source code is licensed under the MIT license found in the
5
- * LICENSE file in the root directory of this source tree.
6
- *
7
- * @flow
8
- */
9
-
10
-import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
11
-import typeof * as ExportsType from './ReactFeatureFlags.testing.www';
12
-
13
-export const debugRenderPhaseSideEffectsForStrictMode = false;
14
-export const enableDebugTracing = false;
15
-export const enableSchedulingProfiler = false;
16
-export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
17
-export const enableProfilerTimer = false;
18
-export const enableProfilerCommitHooks = false;
19
-export const enableProfilerNestedUpdatePhase = false;
20
-export const enableProfilerNestedUpdateScheduledHook = false;
21
-export const enableUpdaterTracking = false;
22
-export const enableCache = true;
23
-export const enableLegacyCache = true;
24
-export const enableCacheElement = true;
25
-export const enableFetchInstrumentation = false;
26
-export const disableJavaScriptURLs = true;
27
-export const disableCommentsAsDOMContainers = true;
28
-export const disableInputAttributeSyncing = false;
29
-export const enableSchedulerDebugging = false;
30
-export const enableScopeAPI = true;
31
-export const enableCreateEventHandleAPI = true;
32
-export const enableSuspenseCallback = true;
33
-export const disableLegacyContext = __EXPERIMENTAL__;
34
-export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
35
-export const enableTrustedTypesIntegration = false;
36
-export const disableTextareaChildren = __EXPERIMENTAL__;
37
-export const disableModulePatternComponents = true;
38
-export const enableSuspenseAvoidThisFallback = true;
39
-export const enableSuspenseAvoidThisFallbackFizz = false;
40
-export const enableCPUSuspense = true;
41
-export const enableUseHook = true;
42
-export const enableUseMemoCacheHook = false;
43
-export const enableUseEffectEventHook = false;
44
-export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
45
- true;
46
-export const enableClientRenderFallbackOnTextMismatch = true;
47
-export const enableComponentStackLocations = true;
48
-export const enableLegacyFBSupport = !__EXPERIMENTAL__;
49
-export const enableFilterEmptyStringAttributesDOM = false;
50
-export const disableNativeComponentFrames = false;
51
-export const skipUnmountedBoundaries = true;
52
-export const enableGetInspectorDataForInstanceInProduction = false;
53
-export const deferRenderPhaseUpdateToNextBatch = false;
54
-
55
-export const createRootStrictEffectsByDefault = false;
56
-export const enableUseRefAccessWarning = false;
57
-
58
-export const disableSchedulerTimeoutInWorkLoop = false;
59
-export const enableLazyContextPropagation = false;
60
-export const enableLegacyHidden = false;
61
-export const enableUnifiedSyncLane = __EXPERIMENTAL__;
62
-export const allowConcurrentByDefault = true;
63
-export const enableCustomElementPropertySupport = false;
64
-
65
-export const consoleManagedByDevToolsDuringStrictMode = false;
66
-export const enableServerContext = true;
67
-// Some www surfaces are still using this. Remove once they have been migrated.
68
-export const enableUseMutableSource = true;
69
-
70
-export const enableTransitionTracing = false;
71
-
72
-export const enableFloat = true;
73
-export const enableHostSingletons = true;
74
-
75
-export const useModernStrictMode = false;
76
-export const enableFizzExternalRuntime = false;
77
-
78
-// Flow magic to verify the exports of this file match the original version.
79
-((((null: any): ExportsType): FeatureFlagsType): ExportsType);
scripts/rollup/forks.js
-8
@@ -135,14 +135,6 @@ const forks = Object.freeze({
135
return './packages/shared/forks/ReactFeatureFlags.test-renderer.www.js';
136
}
137
return './packages/shared/forks/ReactFeatureFlags.test-renderer.js';
138
- case 'react-dom/unstable_testing':
139
- switch (bundleType) {
140
- case FB_WWW_DEV:
141
- case FB_WWW_PROD:
142
- case FB_WWW_PROFILING:
143
- return './packages/shared/forks/ReactFeatureFlags.testing.www.js';
144
- }
145
- return './packages/shared/forks/ReactFeatureFlags.testing.js';
138
default:
139
switch (bundleType) {
140
case FB_WWW_DEV: