rename this tip to be less confusing
Using props to initialize state is completely fine; the issue is using state as a "cache" for values calculated based off of props. This title makes it more clear.
Jared Forsyth committed
Dec 10, 2013 at 11:50 UTC
7640e5310219577ab4a9f8ea3b2683623632fc3b
1 file changed
+2
-2
docs/tips/10-props-in-getInitialState-as-anti-pattern.md
+2
-2
@@ -1,6 +1,6 @@
1
---
2
id: props-in-getInitialState-as-anti-pattern
3
-title: Props in getInitialState Is an Anti-Pattern
3
+title: Using state to cache calculations is an antipattern
4
layout: tips
5
permalink: props-in-getInitialState-as-anti-pattern.html
6
prev: componentWillReceiveProps-not-triggered-after-mounting.html
@@ -11,7 +11,7 @@ next: dom-event-listeners.html
11
>
12
> This isn't really a React-specific tip, as such anti-patterns often occur in code in general; in this case, React simply points them out more clearly.
13
14
-Using props, passed down from parent, to generate state in `getInitialState` often leads to duplication of "source of truth", i.e. where the real data is. Whenever possible, compute values on-the-fly to ensure that they don't get out of sync later on and cause maintenance trouble.
14
+Using state to cache values calculated from props (for example in `getInitialState`) often leads to duplication of "source of truth", i.e. where the real data is. Whenever possible, compute values on-the-fly to ensure that they don't get out of sync later on and cause maintenance trouble.
15
16
Bad example:
17