@samitouri / QOS-React-2 / commits / 79beb71d69

Fix ChangeEventPlugin Dependencies

When React moved to attaching top-level event listeners on-demand, not all of the dependencies for `ChangeEventPlugin` were set. This led to `onChange` events not firing under certain circumstances. For example, listening to `onChange` on a checkbox will not work because it relies on `onClick` (unless something else on the page was listening to `onClick`).

Tim Yung committed Jan 17, 2014 at 12:47 UTC 79beb71d69c8c0c6c6c3ee432f9d7c335ed3157a
1 file changed +3 -1
src/eventPlugins/ChangeEventPlugin.js
+3 -1
@@ -40,10 +40,12 @@ var eventTypes = {
40 dependencies: [
41 topLevelTypes.topBlur,
42 topLevelTypes.topChange,
43 + topLevelTypes.topClick,
44 topLevelTypes.topFocus,
45 topLevelTypes.topInput,
46 topLevelTypes.topKeyDown,
46 - topLevelTypes.topKeyUp
47 + topLevelTypes.topKeyUp,
48 + topLevelTypes.topSelectionChange
49 ]
50 }
51 };