Run more flags in VARIANT tests (#18461)
* Run more flags in VARIANT tests * Revert enabling modern system * Fix
Dan Abramov committed
Apr 2, 2020 at 16:19 UTC
7dfdff42af8e128326672608c9cf8980e289c423
2 files changed
+10
-3
packages/react-interactions/events/src/dom/__tests__/Input-test.internal.js
+9
-2
@@ -140,8 +140,15 @@ describe('Input event responder', () => {
140
ref.current.dispatchEvent(
141
new Event('input', {bubbles: true, cancelable: true}),
142
);
143
- expect(onChangeCalled).toBe(0);
144
- expect(onValueChangeCalled).toBe(0);
143
+
144
+ if (ReactFeatureFlags.disableInputAttributeSyncing) {
145
+ // TODO: figure out why. This might be a bug.
146
+ expect(onChangeCalled).toBe(1);
147
+ expect(onValueChangeCalled).toBe(1);
148
+ } else {
149
+ expect(onChangeCalled).toBe(0);
150
+ expect(onValueChangeCalled).toBe(0);
151
+ }
152
});
153
154
it('should consider initial checkbox checked=true to be current', () => {
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
+1
-1
@@ -15,6 +15,7 @@
15
16
export const warnAboutSpreadingKeyToJSX = __VARIANT__;
17
export const disableModulePatternComponents = __VARIANT__;
18
+export const disableInputAttributeSyncing = __VARIANT__;
19
20
// These are already tested in both modes using the build type dimension,
21
// so we don't need to use __VARIANT__ to get extra coverage.
@@ -25,6 +26,5 @@ export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
26
// Update the tests so that they pass in either mode, then set these
27
// to __VARIANT__.
28
export const enableTrustedTypesIntegration = false;
28
-export const disableInputAttributeSyncing = false;
29
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
30
export const enableModernEventSystem = false;