Enabled enableProfilerChangedHookIndices feature flag for all builds (#22365)
Brian Vaughn committed
Sep 20, 2021 at 13:10 UTC
7e8fb98e140a520bbb723d5930cc657b5fb92488
3 files changed
+97
-2
packages/react-devtools-shared/src/__tests__/__snapshots__/profilingCache-test.js.snap
+95
@@ -206,6 +206,7 @@ Object {
206
4 => Object {
207
"context": null,
208
"didHooksChange": false,
209
+ "hooks": null,
210
"isFirstMount": false,
211
"props": Array [],
212
"state": null,
@@ -213,6 +214,7 @@ Object {
214
5 => Object {
215
"context": null,
216
"didHooksChange": false,
217
+ "hooks": null,
218
"isFirstMount": false,
219
"props": Array [],
220
"state": null,
@@ -227,6 +229,7 @@ Object {
229
2 => Object {
230
"context": null,
231
"didHooksChange": false,
232
+ "hooks": null,
233
"isFirstMount": false,
234
"props": Array [
235
"count",
@@ -271,6 +274,7 @@ Object {
274
4 => Object {
275
"context": null,
276
"didHooksChange": false,
277
+ "hooks": null,
278
"isFirstMount": false,
279
"props": Array [],
280
"state": null,
@@ -278,6 +282,7 @@ Object {
282
2 => Object {
283
"context": null,
284
"didHooksChange": false,
285
+ "hooks": null,
286
"isFirstMount": false,
287
"props": Array [
288
"count",
@@ -318,6 +323,7 @@ Object {
323
2 => Object {
324
"context": null,
325
"didHooksChange": false,
326
+ "hooks": null,
327
"isFirstMount": false,
328
"props": Array [
329
"count",
@@ -464,6 +470,7 @@ Object {
470
Object {
471
"context": null,
472
"didHooksChange": false,
473
+ "hooks": null,
474
"isFirstMount": false,
475
"props": Array [],
476
"state": null,
@@ -474,6 +481,7 @@ Object {
481
Object {
482
"context": null,
483
"didHooksChange": false,
484
+ "hooks": null,
485
"isFirstMount": false,
486
"props": Array [],
487
"state": null,
@@ -494,6 +502,7 @@ Object {
502
Object {
503
"context": null,
504
"didHooksChange": false,
505
+ "hooks": null,
506
"isFirstMount": false,
507
"props": Array [
508
"count",
@@ -568,6 +577,7 @@ Object {
577
Object {
578
"context": null,
579
"didHooksChange": false,
580
+ "hooks": null,
581
"isFirstMount": false,
582
"props": Array [],
583
"state": null,
@@ -578,6 +588,7 @@ Object {
588
Object {
589
"context": null,
590
"didHooksChange": false,
591
+ "hooks": null,
592
"isFirstMount": false,
593
"props": Array [
594
"count",
@@ -636,6 +647,7 @@ Object {
647
Object {
648
"context": null,
649
"didHooksChange": false,
650
+ "hooks": null,
651
"isFirstMount": false,
652
"props": Array [
653
"count",
@@ -957,6 +969,7 @@ Object {
969
Object {
970
"context": null,
971
"didHooksChange": false,
972
+ "hooks": null,
973
"isFirstMount": false,
974
"props": Array [],
975
"state": null,
@@ -977,6 +990,7 @@ Object {
990
Object {
991
"context": null,
992
"didHooksChange": false,
993
+ "hooks": null,
994
"isFirstMount": false,
995
"props": Array [
996
"count",
@@ -1043,6 +1057,7 @@ Object {
1057
Object {
1058
"context": null,
1059
"didHooksChange": false,
1060
+ "hooks": null,
1061
"isFirstMount": false,
1062
"props": Array [],
1063
"state": null,
@@ -1053,6 +1068,7 @@ Object {
1068
Object {
1069
"context": null,
1070
"didHooksChange": false,
1071
+ "hooks": null,
1072
"isFirstMount": false,
1073
"props": Array [],
1074
"state": null,
@@ -1073,6 +1089,7 @@ Object {
1089
Object {
1090
"context": null,
1091
"didHooksChange": false,
1092
+ "hooks": null,
1093
"isFirstMount": false,
1094
"props": Array [
1095
"count",
@@ -1290,6 +1307,7 @@ Object {
1307
4 => Object {
1308
"context": null,
1309
"didHooksChange": false,
1310
+ "hooks": null,
1311
"isFirstMount": false,
1312
"props": Array [],
1313
"state": null,
@@ -1297,6 +1315,7 @@ Object {
1315
5 => Object {
1316
"context": null,
1317
"didHooksChange": false,
1318
+ "hooks": null,
1319
"isFirstMount": false,
1320
"props": Array [],
1321
"state": null,
@@ -1311,6 +1330,7 @@ Object {
1330
2 => Object {
1331
"context": null,
1332
"didHooksChange": false,
1333
+ "hooks": null,
1334
"isFirstMount": false,
1335
"props": Array [
1336
"count",
@@ -1352,6 +1372,7 @@ Object {
1372
4 => Object {
1373
"context": null,
1374
"didHooksChange": false,
1375
+ "hooks": null,
1376
"isFirstMount": false,
1377
"props": Array [],
1378
"state": null,
@@ -1359,6 +1380,7 @@ Object {
1380
2 => Object {
1381
"context": null,
1382
"didHooksChange": false,
1383
+ "hooks": null,
1384
"isFirstMount": false,
1385
"props": Array [
1386
"count",
@@ -1396,6 +1418,7 @@ Object {
1418
2 => Object {
1419
"context": null,
1420
"didHooksChange": false,
1421
+ "hooks": null,
1422
"isFirstMount": false,
1423
"props": Array [
1424
"count",
@@ -1777,6 +1800,7 @@ Object {
1800
Object {
1801
"context": null,
1802
"didHooksChange": false,
1803
+ "hooks": null,
1804
"isFirstMount": false,
1805
"props": Array [],
1806
"state": null,
@@ -1787,6 +1811,7 @@ Object {
1811
Object {
1812
"context": null,
1813
"didHooksChange": false,
1814
+ "hooks": null,
1815
"isFirstMount": false,
1816
"props": Array [],
1817
"state": null,
@@ -1807,6 +1832,7 @@ Object {
1832
Object {
1833
"context": null,
1834
"didHooksChange": false,
1835
+ "hooks": null,
1836
"isFirstMount": false,
1837
"props": Array [
1838
"count",
@@ -1881,6 +1907,7 @@ Object {
1907
Object {
1908
"context": null,
1909
"didHooksChange": false,
1910
+ "hooks": null,
1911
"isFirstMount": false,
1912
"props": Array [],
1913
"state": null,
@@ -1891,6 +1918,7 @@ Object {
1918
Object {
1919
"context": null,
1920
"didHooksChange": false,
1921
+ "hooks": null,
1922
"isFirstMount": false,
1923
"props": Array [
1924
"count",
@@ -1949,6 +1977,7 @@ Object {
1977
Object {
1978
"context": null,
1979
"didHooksChange": false,
1980
+ "hooks": null,
1981
"isFirstMount": false,
1982
"props": Array [
1983
"count",
@@ -2528,6 +2557,7 @@ Object {
2557
4 => Object {
2558
"context": false,
2559
"didHooksChange": false,
2560
+ "hooks": Array [],
2561
"isFirstMount": false,
2562
"props": Array [
2563
"count",
@@ -2570,6 +2600,9 @@ Object {
2600
4 => Object {
2601
"context": false,
2602
"didHooksChange": true,
2603
+ "hooks": Array [
2604
+ 1,
2605
+ ],
2606
"isFirstMount": false,
2607
"props": Array [],
2608
"state": null,
@@ -2604,6 +2637,9 @@ Object {
2637
4 => Object {
2638
"context": false,
2639
"didHooksChange": true,
2640
+ "hooks": Array [
2641
+ 0,
2642
+ ],
2643
"isFirstMount": false,
2644
"props": Array [],
2645
"state": null,
@@ -2638,6 +2674,7 @@ Object {
2674
4 => Object {
2675
"context": true,
2676
"didHooksChange": false,
2677
+ "hooks": Array [],
2678
"isFirstMount": false,
2679
"props": Array [],
2680
"state": null,
@@ -2678,6 +2715,7 @@ Object {
2715
4 => Object {
2716
"context": true,
2717
"didHooksChange": false,
2718
+ "hooks": Array [],
2719
"isFirstMount": false,
2720
"props": Array [],
2721
"state": null,
@@ -2788,6 +2826,7 @@ Object {
2826
Object {
2827
"context": false,
2828
"didHooksChange": false,
2829
+ "hooks": Array [],
2830
"isFirstMount": false,
2831
"props": Array [
2832
"count",
@@ -2854,6 +2893,9 @@ Object {
2893
Object {
2894
"context": false,
2895
"didHooksChange": true,
2896
+ "hooks": Array [
2897
+ 1,
2898
+ ],
2899
"isFirstMount": false,
2900
"props": Array [],
2901
"state": null,
@@ -2894,6 +2936,9 @@ Object {
2936
Object {
2937
"context": false,
2938
"didHooksChange": true,
2939
+ "hooks": Array [
2940
+ 0,
2941
+ ],
2942
"isFirstMount": false,
2943
"props": Array [],
2944
"state": null,
@@ -2934,6 +2979,7 @@ Object {
2979
Object {
2980
"context": true,
2981
"didHooksChange": false,
2982
+ "hooks": Array [],
2983
"isFirstMount": false,
2984
"props": Array [],
2985
"state": null,
@@ -2998,6 +3044,7 @@ Object {
3044
Object {
3045
"context": true,
3046
"didHooksChange": false,
3047
+ "hooks": Array [],
3048
"isFirstMount": false,
3049
"props": Array [],
3050
"state": null,
@@ -3240,6 +3287,9 @@ Object {
3287
5 => Object {
3288
"context": null,
3289
"didHooksChange": true,
3290
+ "hooks": Array [
3291
+ 0,
3292
+ ],
3293
"isFirstMount": false,
3294
"props": Array [
3295
"count",
@@ -3249,6 +3299,7 @@ Object {
3299
4 => Object {
3300
"context": true,
3301
"didHooksChange": false,
3302
+ "hooks": null,
3303
"isFirstMount": false,
3304
"props": Array [],
3305
"state": null,
@@ -3256,6 +3307,9 @@ Object {
3307
7 => Object {
3308
"context": null,
3309
"didHooksChange": true,
3310
+ "hooks": Array [
3311
+ 0,
3312
+ ],
3313
"isFirstMount": false,
3314
"props": Array [
3315
"count",
@@ -3267,6 +3321,7 @@ Object {
3321
"count",
3322
],
3323
"didHooksChange": false,
3324
+ "hooks": null,
3325
"isFirstMount": false,
3326
"props": Array [],
3327
"state": null,
@@ -3274,6 +3329,7 @@ Object {
3329
2 => Object {
3330
"context": null,
3331
"didHooksChange": false,
3332
+ "hooks": Array [],
3333
"isFirstMount": false,
3334
"props": Array [],
3335
"state": Array [
@@ -3320,6 +3376,7 @@ Object {
3376
5 => Object {
3377
"context": null,
3378
"didHooksChange": false,
3379
+ "hooks": Array [],
3380
"isFirstMount": false,
3381
"props": Array [],
3382
"state": null,
@@ -3327,6 +3384,7 @@ Object {
3384
4 => Object {
3385
"context": false,
3386
"didHooksChange": false,
3387
+ "hooks": null,
3388
"isFirstMount": false,
3389
"props": Array [],
3390
"state": null,
@@ -3334,6 +3392,7 @@ Object {
3392
7 => Object {
3393
"context": null,
3394
"didHooksChange": false,
3395
+ "hooks": Array [],
3396
"isFirstMount": false,
3397
"props": Array [],
3398
"state": null,
@@ -3341,6 +3400,7 @@ Object {
3400
6 => Object {
3401
"context": Array [],
3402
"didHooksChange": false,
3403
+ "hooks": null,
3404
"isFirstMount": false,
3405
"props": Array [],
3406
"state": null,
@@ -3348,6 +3408,7 @@ Object {
3408
2 => Object {
3409
"context": null,
3410
"didHooksChange": false,
3411
+ "hooks": Array [],
3412
"isFirstMount": false,
3413
"props": Array [
3414
"foo",
@@ -3396,6 +3457,7 @@ Object {
3457
5 => Object {
3458
"context": null,
3459
"didHooksChange": false,
3460
+ "hooks": Array [],
3461
"isFirstMount": false,
3462
"props": Array [],
3463
"state": null,
@@ -3403,6 +3465,7 @@ Object {
3465
4 => Object {
3466
"context": false,
3467
"didHooksChange": false,
3468
+ "hooks": null,
3469
"isFirstMount": false,
3470
"props": Array [],
3471
"state": null,
@@ -3410,6 +3473,7 @@ Object {
3473
7 => Object {
3474
"context": null,
3475
"didHooksChange": false,
3476
+ "hooks": Array [],
3477
"isFirstMount": false,
3478
"props": Array [],
3479
"state": null,
@@ -3417,6 +3481,7 @@ Object {
3481
6 => Object {
3482
"context": Array [],
3483
"didHooksChange": false,
3484
+ "hooks": null,
3485
"isFirstMount": false,
3486
"props": Array [],
3487
"state": null,
@@ -3424,6 +3489,7 @@ Object {
3489
2 => Object {
3490
"context": null,
3491
"didHooksChange": false,
3492
+ "hooks": Array [],
3493
"isFirstMount": false,
3494
"props": Array [
3495
"foo",
@@ -3473,6 +3539,7 @@ Object {
3539
5 => Object {
3540
"context": null,
3541
"didHooksChange": false,
3542
+ "hooks": Array [],
3543
"isFirstMount": false,
3544
"props": Array [],
3545
"state": null,
@@ -3480,6 +3547,7 @@ Object {
3547
4 => Object {
3548
"context": false,
3549
"didHooksChange": false,
3550
+ "hooks": null,
3551
"isFirstMount": false,
3552
"props": Array [],
3553
"state": null,
@@ -3487,6 +3555,7 @@ Object {
3555
7 => Object {
3556
"context": null,
3557
"didHooksChange": false,
3558
+ "hooks": Array [],
3559
"isFirstMount": false,
3560
"props": Array [],
3561
"state": null,
@@ -3494,6 +3563,7 @@ Object {
3563
6 => Object {
3564
"context": Array [],
3565
"didHooksChange": false,
3566
+ "hooks": null,
3567
"isFirstMount": false,
3568
"props": Array [],
3569
"state": null,
@@ -3501,6 +3571,7 @@ Object {
3571
2 => Object {
3572
"context": null,
3573
"didHooksChange": false,
3574
+ "hooks": Array [],
3575
"isFirstMount": false,
3576
"props": Array [
3577
"bar",
@@ -3683,6 +3754,9 @@ Object {
3754
Object {
3755
"context": null,
3756
"didHooksChange": true,
3757
+ "hooks": Array [
3758
+ 0,
3759
+ ],
3760
"isFirstMount": false,
3761
"props": Array [
3762
"count",
@@ -3695,6 +3769,7 @@ Object {
3769
Object {
3770
"context": true,
3771
"didHooksChange": false,
3772
+ "hooks": null,
3773
"isFirstMount": false,
3774
"props": Array [],
3775
"state": null,
@@ -3705,6 +3780,9 @@ Object {
3780
Object {
3781
"context": null,
3782
"didHooksChange": true,
3783
+ "hooks": Array [
3784
+ 0,
3785
+ ],
3786
"isFirstMount": false,
3787
"props": Array [
3788
"count",
@@ -3719,6 +3797,7 @@ Object {
3797
"count",
3798
],
3799
"didHooksChange": false,
3800
+ "hooks": null,
3801
"isFirstMount": false,
3802
"props": Array [],
3803
"state": null,
@@ -3729,6 +3808,7 @@ Object {
3808
Object {
3809
"context": null,
3810
"didHooksChange": false,
3811
+ "hooks": Array [],
3812
"isFirstMount": false,
3813
"props": Array [],
3814
"state": Array [
@@ -3811,6 +3891,7 @@ Object {
3891
Object {
3892
"context": null,
3893
"didHooksChange": false,
3894
+ "hooks": Array [],
3895
"isFirstMount": false,
3896
"props": Array [],
3897
"state": null,
@@ -3821,6 +3902,7 @@ Object {
3902
Object {
3903
"context": false,
3904
"didHooksChange": false,
3905
+ "hooks": null,
3906
"isFirstMount": false,
3907
"props": Array [],
3908
"state": null,
@@ -3831,6 +3913,7 @@ Object {
3913
Object {
3914
"context": null,
3915
"didHooksChange": false,
3916
+ "hooks": Array [],
3917
"isFirstMount": false,
3918
"props": Array [],
3919
"state": null,
@@ -3841,6 +3924,7 @@ Object {
3924
Object {
3925
"context": Array [],
3926
"didHooksChange": false,
3927
+ "hooks": null,
3928
"isFirstMount": false,
3929
"props": Array [],
3930
"state": null,
@@ -3851,6 +3935,7 @@ Object {
3935
Object {
3936
"context": null,
3937
"didHooksChange": false,
3938
+ "hooks": Array [],
3939
"isFirstMount": false,
3940
"props": Array [
3941
"foo",
@@ -3941,6 +4026,7 @@ Object {
4026
Object {
4027
"context": null,
4028
"didHooksChange": false,
4029
+ "hooks": Array [],
4030
"isFirstMount": false,
4031
"props": Array [],
4032
"state": null,
@@ -3951,6 +4037,7 @@ Object {
4037
Object {
4038
"context": false,
4039
"didHooksChange": false,
4040
+ "hooks": null,
4041
"isFirstMount": false,
4042
"props": Array [],
4043
"state": null,
@@ -3961,6 +4048,7 @@ Object {
4048
Object {
4049
"context": null,
4050
"didHooksChange": false,
4051
+ "hooks": Array [],
4052
"isFirstMount": false,
4053
"props": Array [],
4054
"state": null,
@@ -3971,6 +4059,7 @@ Object {
4059
Object {
4060
"context": Array [],
4061
"didHooksChange": false,
4062
+ "hooks": null,
4063
"isFirstMount": false,
4064
"props": Array [],
4065
"state": null,
@@ -3981,6 +4070,7 @@ Object {
4070
Object {
4071
"context": null,
4072
"didHooksChange": false,
4073
+ "hooks": Array [],
4074
"isFirstMount": false,
4075
"props": Array [
4076
"foo",
@@ -4072,6 +4162,7 @@ Object {
4162
Object {
4163
"context": null,
4164
"didHooksChange": false,
4165
+ "hooks": Array [],
4166
"isFirstMount": false,
4167
"props": Array [],
4168
"state": null,
@@ -4082,6 +4173,7 @@ Object {
4173
Object {
4174
"context": false,
4175
"didHooksChange": false,
4176
+ "hooks": null,
4177
"isFirstMount": false,
4178
"props": Array [],
4179
"state": null,
@@ -4092,6 +4184,7 @@ Object {
4184
Object {
4185
"context": null,
4186
"didHooksChange": false,
4187
+ "hooks": Array [],
4188
"isFirstMount": false,
4189
"props": Array [],
4190
"state": null,
@@ -4102,6 +4195,7 @@ Object {
4195
Object {
4196
"context": Array [],
4197
"didHooksChange": false,
4198
+ "hooks": null,
4199
"isFirstMount": false,
4200
"props": Array [],
4201
"state": null,
@@ -4112,6 +4206,7 @@ Object {
4206
Object {
4207
"context": null,
4208
"didHooksChange": false,
4209
+ "hooks": Array [],
4210
"isFirstMount": false,
4211
"props": Array [
4212
"bar",
packages/react-devtools-shared/src/config/DevToolsFeatureFlags.core-oss.js
+1
-1
@@ -13,7 +13,7 @@
13
* It should always be imported from "react-devtools-feature-flags".
14
************************************************************************/
15
16
-export const enableProfilerChangedHookIndices = false;
16
+export const enableProfilerChangedHookIndices = true;
17
export const isInternalFacebookBuild = false;
18
export const enableNamedHooksFeature = true;
19
export const enableLogger = false;
packages/react-devtools-shared/src/config/DevToolsFeatureFlags.default.js
+1
-1
@@ -13,7 +13,7 @@
13
* It should always be imported from "react-devtools-feature-flags".
14
************************************************************************/
15
16
-export const enableProfilerChangedHookIndices = false;
16
+export const enableProfilerChangedHookIndices = true;
17
export const isInternalFacebookBuild = false;
18
export const enableNamedHooksFeature = true;
19
export const enableLogger = false;