Enable component stacks everywhere except RN (#19120)
This would still affect test renderer and isomorphic in RN.
Sebastian Markbåge committed
Jun 11, 2020 at 19:13 UTC
7f28234f8468d23dac7980be55e1a20f86a7b915
7 files changed
+11
-8
fixtures/dom/src/__tests__/wrong-act-test.js
+6
-2
@@ -118,7 +118,9 @@ it('warns when using the wrong act version - test + dom: updates', () => {
118
TestRenderer.act(() => {
119
setCtr(1);
120
});
121
- }).toWarnDev(["It looks like you're using the wrong act()"]);
121
+ }).toWarnDev(["It looks like you're using the wrong act()"], {
122
+ withoutStack: true,
123
+ });
124
});
125
126
it('warns when using the wrong act version - dom + test: .create()', () => {
@@ -154,7 +156,9 @@ it('warns when using the wrong act version - dom + test: updates', () => {
156
TestUtils.act(() => {
157
setCtr(1);
158
});
157
- }).toWarnDev(["It looks like you're using the wrong act()"]);
159
+ }).toWarnDev(["It looks like you're using the wrong act()"], {
160
+ withoutStack: true,
161
+ });
162
});
163
164
it('does not warn when nesting react-act inside react-dom', () => {
packages/shared/ReactFeatureFlags.js
+1
-1
@@ -87,7 +87,7 @@ export const enableTrustedTypesIntegration = false;
87
// a deprecated pattern we want to get rid of in the future
88
export const warnAboutSpreadingKeyToJSX = false;
89
90
-export const enableComponentStackLocations = __EXPERIMENTAL__;
90
+export const enableComponentStackLocations = true;
91
92
export const enableNewReconciler = false;
93
packages/shared/forks/ReactFeatureFlags.test-renderer.js
+1
-1
@@ -40,7 +40,7 @@ export const disableModulePatternComponents = false;
40
export const warnUnstableRenderSubtreeIntoContainer = false;
41
export const enableModernEventSystem = false;
42
export const warnAboutSpreadingKeyToJSX = false;
43
-export const enableComponentStackLocations = false;
43
+export const enableComponentStackLocations = true;
44
export const enableLegacyFBSupport = false;
45
export const enableFilterEmptyStringAttributesDOM = false;
46
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
+1
-1
@@ -40,7 +40,7 @@ export const disableModulePatternComponents = true;
40
export const warnUnstableRenderSubtreeIntoContainer = false;
41
export const enableModernEventSystem = false;
42
export const warnAboutSpreadingKeyToJSX = false;
43
-export const enableComponentStackLocations = false;
43
+export const enableComponentStackLocations = true;
44
export const enableLegacyFBSupport = false;
45
export const enableFilterEmptyStringAttributesDOM = false;
46
packages/shared/forks/ReactFeatureFlags.testing.js
+1
-1
@@ -40,7 +40,7 @@ export const disableModulePatternComponents = false;
40
export const warnUnstableRenderSubtreeIntoContainer = false;
41
export const enableModernEventSystem = false;
42
export const warnAboutSpreadingKeyToJSX = false;
43
-export const enableComponentStackLocations = false;
43
+export const enableComponentStackLocations = true;
44
export const enableLegacyFBSupport = false;
45
export const enableFilterEmptyStringAttributesDOM = false;
46
packages/shared/forks/ReactFeatureFlags.testing.www.js
+1
-1
@@ -40,7 +40,7 @@ export const disableModulePatternComponents = true;
40
export const warnUnstableRenderSubtreeIntoContainer = false;
41
export const enableModernEventSystem = false;
42
export const warnAboutSpreadingKeyToJSX = false;
43
-export const enableComponentStackLocations = false;
43
+export const enableComponentStackLocations = true;
44
export const enableLegacyFBSupport = !__EXPERIMENTAL__;
45
export const enableFilterEmptyStringAttributesDOM = false;
46
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-1
@@ -14,7 +14,6 @@
14
// with the __VARIANT__ set to `true`, and once set to `false`.
15
16
export const warnAboutSpreadingKeyToJSX = __VARIANT__;
17
-export const enableComponentStackLocations = __VARIANT__;
17
export const disableInputAttributeSyncing = __VARIANT__;
18
export const enableFilterEmptyStringAttributesDOM = __VARIANT__;
19
export const enableLegacyFBSupport = __VARIANT__;