Remove unused feature flag disableSchedulerTimeoutBasedOnReactExpirationTime (#26488)
Easy removal as it's completely unused as @rickhanlonii noticed.
Jan Kassens committed
Mar 27, 2023 at 17:52 UTC
8342a09927b18725e1dd2a78b9a78b439528a7d1
9 files changed
-108
packages/react-reconciler/src/__tests__/ReactDisableSchedulerTimeoutBasedOnReactExpirationTime-test.internal.js
deleted
-100
@@ -1,100 +0,0 @@
1
-let React;
2
-let ReactFeatureFlags;
3
-let ReactNoop;
4
-let Scheduler;
5
-let Suspense;
6
-let scheduleCallback;
7
-let NormalPriority;
8
-let waitForAll;
9
-let waitFor;
10
-
11
-describe('ReactSuspenseList', () => {
12
- beforeEach(() => {
13
- jest.resetModules();
14
- ReactFeatureFlags = require('shared/ReactFeatureFlags');
15
-
16
- ReactFeatureFlags.replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
17
- ReactFeatureFlags.disableSchedulerTimeoutBasedOnReactExpirationTime = true;
18
- React = require('react');
19
- ReactNoop = require('react-noop-renderer');
20
- Scheduler = require('scheduler');
21
- Suspense = React.Suspense;
22
-
23
- scheduleCallback = Scheduler.unstable_scheduleCallback;
24
- NormalPriority = Scheduler.unstable_NormalPriority;
25
-
26
- const InternalTestUtils = require('internal-test-utils');
27
- waitForAll = InternalTestUtils.waitForAll;
28
- waitFor = InternalTestUtils.waitFor;
29
- });
30
-
31
- function Text(props) {
32
- Scheduler.log(props.text);
33
- return props.text;
34
- }
35
-
36
- function createAsyncText(text) {
37
- let resolved = false;
38
- const Component = function () {
39
- if (!resolved) {
40
- Scheduler.log('Suspend! [' + text + ']');
41
- throw promise;
42
- }
43
- return <Text text={text} />;
44
- };
45
- const promise = new Promise(resolve => {
46
- Component.resolve = function () {
47
- resolved = true;
48
- return resolve();
49
- };
50
- });
51
- return Component;
52
- }
53
-
54
- it('appends rendering tasks to the end of the priority queue', async () => {
55
- const A = createAsyncText('A');
56
- const B = createAsyncText('B');
57
-
58
- function App({show}) {
59
- return (
60
- <Suspense fallback={<Text text="Loading..." />}>
61
- {show ? <A /> : null}
62
- {show ? <B /> : null}
63
- </Suspense>
64
- );
65
- }
66
-
67
- const root = ReactNoop.createRoot(null);
68
-
69
- root.render(<App show={false} />);
70
- await waitForAll([]);
71
-
72
- React.startTransition(() => {
73
- root.render(<App show={true} />);
74
- });
75
- await waitForAll(['Suspend! [A]', 'Loading...']);
76
- expect(root).toMatchRenderedOutput(null);
77
-
78
- Scheduler.unstable_advanceTime(2000);
79
- expect(root).toMatchRenderedOutput(null);
80
-
81
- scheduleCallback(NormalPriority, () => {
82
- Scheduler.log('Resolve A');
83
- A.resolve();
84
- });
85
- scheduleCallback(NormalPriority, () => {
86
- Scheduler.log('Resolve B');
87
- B.resolve();
88
- });
89
-
90
- // This resolves A and schedules a task for React to retry.
91
- await waitFor(['Resolve A']);
92
-
93
- // The next task that flushes should be the one that resolves B. The render
94
- // task should not jump the queue ahead of B.
95
- await waitFor(['Resolve B']);
96
-
97
- await waitForAll(['A', 'B']);
98
- expect(root).toMatchRenderedOutput('AB');
99
- });
100
-});
packages/shared/ReactFeatureFlags.js
-1
@@ -14,7 +14,6 @@
14
// -----------------------------------------------------------------------------
15
16
export const enableComponentStackLocations = true;
17
-export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
17
18
// -----------------------------------------------------------------------------
19
// Killswitch
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -42,7 +42,6 @@ export const enableScopeAPI = false;
42
export const enableCreateEventHandleAPI = false;
43
export const enableSuspenseCallback = false;
44
export const disableLegacyContext = false;
45
-export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
45
export const revertRemovalOfSiblingPrerendering = false;
46
export const enableTrustedTypesIntegration = false;
47
export const disableTextareaChildren = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -32,7 +32,6 @@ export const enableScopeAPI = false;
32
export const enableCreateEventHandleAPI = false;
33
export const enableSuspenseCallback = false;
34
export const disableLegacyContext = false;
35
-export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
35
export const revertRemovalOfSiblingPrerendering = false;
36
export const enableTrustedTypesIntegration = false;
37
export const disableTextareaChildren = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -32,7 +32,6 @@ export const enableScopeAPI = false;
32
export const enableCreateEventHandleAPI = false;
33
export const enableSuspenseCallback = false;
34
export const disableLegacyContext = false;
35
-export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
35
export const revertRemovalOfSiblingPrerendering = false;
36
export const enableTrustedTypesIntegration = false;
37
export const disableTextareaChildren = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
-1
@@ -32,7 +32,6 @@ export const enableScopeAPI = false;
32
export const enableCreateEventHandleAPI = false;
33
export const enableSuspenseCallback = false;
34
export const disableLegacyContext = false;
35
-export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
35
export const revertRemovalOfSiblingPrerendering = false;
36
export const enableTrustedTypesIntegration = false;
37
export const disableTextareaChildren = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -32,7 +32,6 @@ export const enableScopeAPI = true;
32
export const enableCreateEventHandleAPI = false;
33
export const enableSuspenseCallback = true;
34
export const disableLegacyContext = false;
35
-export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
35
export const revertRemovalOfSiblingPrerendering = false;
36
export const enableTrustedTypesIntegration = false;
37
export const disableTextareaChildren = false;
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-1
@@ -59,7 +59,6 @@ export const revertRemovalOfSiblingPrerendering = false;
59
// Update the tests so that they pass in either mode, then set these
60
// to __VARIANT__.
61
export const enableTrustedTypesIntegration = false;
62
-export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
62
export const disableNativeComponentFrames = false;
63
// You probably *don't* want to add more hardcoded ones.
64
// Instead, try to add them above with the __VARIANT__ value.
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -18,7 +18,6 @@ export const {
18
disableInputAttributeSyncing,
19
disableIEWorkarounds,
20
enableTrustedTypesIntegration,
21
- disableSchedulerTimeoutBasedOnReactExpirationTime,
21
revertRemovalOfSiblingPrerendering,
22
replayFailedUnitOfWorkWithInvokeGuardedCallback,
23
enableLegacyFBSupport,