Remove `.internal` from more test suites (#18597)
Andrew Clark committed
Apr 14, 2020 at 07:43 UTC
843b50cbe154bd6559236c3575ae707404292c23
6 files changed
+9
-10
packages/react-dom/src/__tests__/ReactDOMServerIntegrationHooks-test.js
renamed
packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js
renamed
+1
-2
@@ -43,8 +43,6 @@ describe('ReactHooksWithNoopRenderer', () => {
43
44
ReactFeatureFlags = require('shared/ReactFeatureFlags');
45
46
- ReactFeatureFlags.enableSchedulerTracing = true;
47
- ReactFeatureFlags.enableProfilerTimer = true;
46
deferPassiveEffectCleanupDuringUnmount =
47
ReactFeatureFlags.deferPassiveEffectCleanupDuringUnmount;
48
runAllPassiveEffectDestroysBeforeCreates =
@@ -1611,6 +1609,7 @@ describe('ReactHooksWithNoopRenderer', () => {
1609
expect(ReactNoop.getChildren()).toEqual([span('Count: 2')]);
1610
});
1611
1612
+ // @gate enableSchedulerTracing
1613
it('flushes passive effects when flushing discrete updates (with tracing)', () => {
1614
const onInteractionScheduledWorkCompleted = jest.fn();
1615
const onWorkCanceled = jest.fn();
packages/react-reconciler/src/__tests__/ReactSuspenseList-test.js
renamed
-4
@@ -1,5 +1,4 @@
1
let React;
2
-let ReactFeatureFlags;
2
let ReactNoop;
3
let Scheduler;
4
let Suspense;
@@ -8,10 +7,7 @@ let SuspenseList;
7
describe('ReactSuspenseList', () => {
8
beforeEach(() => {
9
jest.resetModules();
11
- ReactFeatureFlags = require('shared/ReactFeatureFlags');
10
13
- ReactFeatureFlags.replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
14
- ReactFeatureFlags.enableSuspenseServerRenderer = true;
11
React = require('react');
12
ReactNoop = require('react-noop-renderer');
13
Scheduler = require('scheduler');
packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js
renamed
+6
-2
@@ -15,8 +15,6 @@ describe('ReactSuspenseWithNoopRenderer', () => {
15
jest.resetModules();
16
17
ReactFeatureFlags = require('shared/ReactFeatureFlags');
18
-
19
- ReactFeatureFlags.replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
18
React = require('react');
19
Fragment = React.Fragment;
20
ReactNoop = require('react-noop-renderer');
@@ -339,6 +337,9 @@ describe('ReactSuspenseWithNoopRenderer', () => {
337
]);
338
});
339
340
+ // Second condition is redundant but guarantees that the test runs in prod.
341
+ // TODO: Delete this feature flag.
342
+ // @gate !replayFailedUnitOfWorkWithInvokeGuardedCallback || !__DEV__
343
it('retries on error', async () => {
344
class ErrorBoundary extends React.Component {
345
state = {error: null};
@@ -395,6 +396,9 @@ describe('ReactSuspenseWithNoopRenderer', () => {
396
]);
397
});
398
399
+ // Second condition is redundant but guarantees that the test runs in prod.
400
+ // TODO: Delete this feature flag.
401
+ // @gate !replayFailedUnitOfWorkWithInvokeGuardedCallback || !__DEV__
402
it('retries on error after falling back to a placeholder', async () => {
403
class ErrorBoundary extends React.Component {
404
state = {error: null};
packages/react-reconciler/src/__tests__/ReactTransition-test.js
renamed
packages/react-reconciler/src/forks/ReactFiberHostConfig.custom.js
+2
-2
@@ -57,8 +57,8 @@ export const shouldSetTextContent = $$$hostConfig.shouldSetTextContent;
57
export const shouldDeprioritizeSubtree =
58
$$$hostConfig.shouldDeprioritizeSubtree;
59
export const createTextInstance = $$$hostConfig.createTextInstance;
60
-export const scheduleTimeout = $$$hostConfig.setTimeout;
61
-export const cancelTimeout = $$$hostConfig.clearTimeout;
60
+export const scheduleTimeout = $$$hostConfig.scheduleTimeout;
61
+export const cancelTimeout = $$$hostConfig.cancelTimeout;
62
export const noTimeout = $$$hostConfig.noTimeout;
63
export const now = $$$hostConfig.now;
64
export const isPrimaryRenderer = $$$hostConfig.isPrimaryRenderer;