Add eslint grunt task, fail travis for it
This is it...
Paul O’Shannessy committed
Jan 13, 2015 at 15:25 UTC
84c83dca2dea73df3a952020b56b2eabef8fc937
2 files changed
+17
-4
.travis.yml
-1
@@ -51,7 +51,6 @@ env:
51
matrix:
52
fast_finish: true
53
allow_failures:
54
- - env: TEST_TYPE=lint
54
- env: TEST_TYPE=test:coverage
55
- env: TEST_TYPE=perf:full
56
- env: TEST_TYPE=test:webdriver:saucelabs:modern
Gruntfile.js
+17
-3
@@ -1,6 +1,5 @@
1
'use strict';
2
3
-var exec = require('child_process').exec;
3
var jsxTask = require('./grunt/tasks/jsx');
4
var browserifyTask = require('./grunt/tasks/browserify');
5
var populistTask = require('./grunt/tasks/populist');
@@ -38,8 +37,23 @@ module.exports = function(grunt) {
37
.filter(function(npmTaskName) { return npmTaskName != 'grunt-cli'; })
38
.forEach(function(npmTaskName) { grunt.loadNpmTasks(npmTaskName); });
39
41
- // Alias 'jshint' to 'lint' to better match the workflow we know
42
- grunt.registerTask('lint', ['jshint']);
40
+ // Super simplified eslint task that we can use to replace linting. This just
41
+ // shells out to eslint.
42
+ grunt.registerTask('eslint', function() {
43
+ var done = this.async();
44
+ grunt.util.spawn({
45
+ cmd: 'node_modules/.bin/eslint',
46
+ args: ['src']
47
+ }, function(err, result, code) {
48
+ if (result.stdout.length) {
49
+ grunt.warn(result.stdout);
50
+ }
51
+
52
+ done(code === 0);
53
+ });
54
+ });
55
+
56
+ grunt.registerTask('lint', ['eslint']);
57
58
grunt.registerTask('download-previous-version', require('./grunt/tasks/download-previous-version.js'));
59