Add error codes update to release process (#8749)
* Add error codes update to release process * Update
Paul O’Shannessy committed
Jan 12, 2017 at 07:13 UTC
8835955218134df61773ae7130291c03843c1c55
1 file changed
+50
scripts/release-manager/Readme.md
+50
@@ -141,6 +141,29 @@ You can fix them in a separate commit.
141
142
**Tip:** tests might also be failing if dependency versions are incorrect. You might want to run `yarn` first since sometimes `package.json` on master is different from the stable branches.
143
144
+### Update the Error Codes
145
+
146
+**This step is only necessary for a stable release.**
147
+If you’re just cutting an alpha, you should skip it.
148
+
149
+Run this so that `scripts/error-codes/codes.json` is up to date:
150
+
151
+```
152
+./node_modules/.bin/gulp react:extract-errors
153
+```
154
+
155
+Check `git diff`. Do changes, if any, look sensible?
156
+
157
+If there are any changes, commit them:
158
+
159
+```
160
+git commit -am 'Update error codes'
161
+```
162
+
163
+You will see the commit hash. Copy it in your editor. You will need it later to cherry-pick the error codes update to master.
164
+
165
+If there were no changes, it’s also fine.
166
+
167
### Push and Choose the Branch
168
169
If you followed the guide correctly (and ran `start-release` in the beginning), you should be on a “stable development” branch such as `15-dev`. Now is a good time to push the development branch:
@@ -330,6 +353,33 @@ Looks good? Push it.
353
git push
354
```
355
356
+### Cherry-Pick the Error Codes
357
+
358
+**This step is only necessary for a stable release.**
359
+If you’re just cutting an alpha, you should skip it.
360
+
361
+If error codes were updated, you were supposed to commit that earlier and record the commit hash.
362
+
363
+Did this happen?
364
+
365
+If so, cherry-pick it to `master` as well:
366
+
367
+```
368
+git cherry-pick <hash of the error codes update commit>
369
+```
370
+
371
+Verify you picked the right commit:
372
+
373
+```
374
+git diff HEAD~
375
+```
376
+
377
+Looks good? Push it.
378
+
379
+```
380
+git push
381
+```
382
+
383
### Creating a GitHub Release
384
385
**This step is only necessary for a stable release.**