@samitouri / QOS-React-2 / commits / 88df88f944

fix: devtools cannot be closed correctly (#25510)

<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary Fix devtools cannot be shutdown by bridge.shutdown(). <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> ## How did you test this change? <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. -->

Jack Works committed Jun 13, 2023 at 17:04 UTC 88df88f9441e0f83917e60e04d4f75118c1adec5
2 files changed +4
packages/react-devtools-shared/src/__tests__/bridge-test.js
+3
@@ -21,6 +21,8 @@ describe('Bridge', () => {
21 send: jest.fn(),
22 };
23 const bridge = new Bridge(wall);
24 + const shutdownCallback = jest.fn();
25 + bridge.addListener('shutdown', shutdownCallback);
26
27 // Check that we're wired up correctly.
28 bridge.send('reloadAppForProfiling');
@@ -36,6 +38,7 @@ describe('Bridge', () => {
38 expect(wall.send).toHaveBeenCalledWith('update', '1');
39 expect(wall.send).toHaveBeenCalledWith('update', '2');
40 expect(wall.send).toHaveBeenCalledWith('shutdown');
41 + expect(shutdownCallback).toHaveBeenCalledTimes(1);
42
43 // Verify that the Bridge doesn't send messages after shutdown.
44 jest.spyOn(console, 'warn').mockImplementation(() => {});
packages/react-devtools-shared/src/bridge.js
+1
@@ -334,6 +334,7 @@ class Bridge<
334 }
335
336 // Queue the shutdown outgoing message for subscribers.
337 + this.emit('shutdown');
338 this.send('shutdown');
339
340 // Mark this bridge as destroyed, i.e. disable its public API.