Remove caching from for loops
Removed caching from for loops as it does not seem to increase performance and makes the code harder to read.
James committed
Mar 31, 2015 at 10:22 UTC
90dcc1ffb7b66d3d8713e730a4bce8bc0617c591
7 files changed
+11
-11
src/browser/ReactBrowserEventEmitter.js
+1
-1
@@ -216,7 +216,7 @@ var ReactBrowserEventEmitter = assign({}, ReactEventEmitterMixin, {
216
registrationNameDependencies[registrationName];
217
218
var topLevelTypes = EventConstants.topLevelTypes;
219
- for (var i = 0, l = dependencies.length; i < l; i++) {
219
+ for (var i = 0; i < dependencies.length; i++) {
220
var dependency = dependencies[i];
221
if (!(
222
isListening.hasOwnProperty(dependency) &&
src/browser/__tests__/ReactBrowserEventEmitter-test.js
+3
-3
@@ -397,10 +397,10 @@ describe('ReactBrowserEventEmitter', function() {
397
var setEventListeners = [];
398
var listenCalls = EventListener.listen.argsForCall;
399
var captureCalls = EventListener.capture.argsForCall;
400
- for (var i = 0, l = listenCalls.length; i < l; i++) {
400
+ for (var i = 0; i < listenCalls.length; i++) {
401
setEventListeners.push(listenCalls[i][1]);
402
}
403
- for (i = 0, l = captureCalls.length; i < l; i++) {
403
+ for (i = 0; i < captureCalls.length; i++) {
404
setEventListeners.push(captureCalls[i][1]);
405
}
406
@@ -409,7 +409,7 @@ describe('ReactBrowserEventEmitter', function() {
409
var dependencies = module.eventTypes.change.dependencies;
410
expect(setEventListeners.length).toEqual(dependencies.length);
411
412
- for (i = 0, l = setEventListeners.length; i < l; i++) {
412
+ for (i = 0; i < setEventListeners.length; i++) {
413
expect(dependencies.indexOf(setEventListeners[i])).toBeTruthy();
414
}
415
});
src/browser/ui/ReactEventListener.js
+1
-1
@@ -74,7 +74,7 @@ function handleTopLevelImpl(bookKeeping) {
74
ancestor = findParent(ancestor);
75
}
76
77
- for (var i = 0, l = bookKeeping.ancestors.length; i < l; i++) {
77
+ for (var i = 0; i < bookKeeping.ancestors.length; i++) {
78
topLevelTarget = bookKeeping.ancestors[i];
79
var topLevelTargetID = ReactMount.getID(topLevelTarget) || '';
80
ReactEventListener._handleTopLevel(
src/browser/ui/dom/components/ReactDOMInput.js
+1
-1
@@ -141,7 +141,7 @@ var ReactDOMInput = ReactClass.createClass({
141
var group = queryRoot.querySelectorAll(
142
'input[name=' + JSON.stringify('' + name) + '][type="radio"]');
143
144
- for (var i = 0, groupLen = group.length; i < groupLen; i++) {
144
+ for (var i = 0; i < group.length; i++) {
145
var otherNode = group[i];
146
if (otherNode === rootNode ||
147
otherNode.form !== rootNode.form) {
src/browser/ui/dom/components/ReactDOMSelect.js
+3
-3
@@ -70,10 +70,10 @@ function updateOptions(component, propValue) {
70
71
if (component.props.multiple) {
72
selectedValue = {};
73
- for (i = 0, l = propValue.length; i < l; i++) {
73
+ for (i = 0; i < propValue.length; i++) {
74
selectedValue['' + propValue[i]] = true;
75
}
76
- for (i = 0, l = options.length; i < l; i++) {
76
+ for (i = 0; i < options.length; i++) {
77
var selected = selectedValue.hasOwnProperty(options[i].value);
78
if (options[i].selected !== selected) {
79
options[i].selected = selected;
@@ -83,7 +83,7 @@ function updateOptions(component, propValue) {
83
// Do not set `select.value` as exact behavior isn't consistent across all
84
// browsers for all cases.
85
selectedValue = '' + propValue;
86
- for (i = 0, l = options.length; i < l; i++) {
86
+ for (i = 0; i < options.length; i++) {
87
if (options[i].value === selectedValue) {
88
options[i].selected = true;
89
return;
src/event/EventPluginHub.js
+1
-1
@@ -233,7 +233,7 @@ var EventPluginHub = {
233
nativeEvent) {
234
var events;
235
var plugins = EventPluginRegistry.plugins;
236
- for (var i = 0, l = plugins.length; i < l; i++) {
236
+ for (var i = 0; i < plugins.length; i++) {
237
// Not every plugin in the ordering may be loaded at runtime.
238
var possiblePlugin = plugins[i];
239
if (possiblePlugin) {
src/utils/CallbackQueue.js
+1
-1
@@ -64,7 +64,7 @@ assign(CallbackQueue.prototype, {
64
);
65
this._callbacks = null;
66
this._contexts = null;
67
- for (var i = 0, l = callbacks.length; i < l; i++) {
67
+ for (var i = 0; i < callbacks.length; i++) {
68
callbacks[i].call(contexts[i]);
69
}
70
callbacks.length = 0;