[react-ui] Remove event object warnings (#16822)
Dominic Gannaway committed
Sep 19, 2019 at 12:46 UTC
924a305780eb71866eb0932027048237b6f5c3cd
2 files changed
-34
packages/react-dom/src/events/DOMEventResponderSystem.js
-10
@@ -303,16 +303,6 @@ function validateEventValue(eventValue: any): void {
303
);
304
}
305
};
306
- eventValue.preventDefault = () => {
307
- if (__DEV__) {
308
- showWarning('preventDefault()');
309
- }
310
- };
311
- eventValue.stopPropagation = () => {
312
- if (__DEV__) {
313
- showWarning('stopPropagation()');
314
- }
315
- };
306
eventValue.isDefaultPrevented = () => {
307
if (__DEV__) {
308
showWarning('isDefaultPrevented()');
packages/react-dom/src/events/__tests__/DOMEventResponderSystem-test.internal.js
-24
@@ -837,30 +837,6 @@ describe('DOMEventResponderSystem', () => {
837
</button>
838
);
839
};
840
- expect(() => {
841
- handler = event => {
842
- event.preventDefault();
843
- };
844
- ReactDOM.render(<Test />, container);
845
- dispatchClickEvent(buttonRef.current);
846
- }).toWarnDev(
847
- 'Warning: preventDefault() is not available on event objects created from event responder modules ' +
848
- '(React Flare).' +
849
- ' Try wrapping in a conditional, i.e. `if (event.type !== "press") { event.preventDefault() }`',
850
- {withoutStack: true},
851
- );
852
- expect(() => {
853
- handler = event => {
854
- event.stopPropagation();
855
- };
856
- ReactDOM.render(<Test />, container);
857
- dispatchClickEvent(buttonRef.current);
858
- }).toWarnDev(
859
- 'Warning: stopPropagation() is not available on event objects created from event responder modules ' +
860
- '(React Flare).' +
861
- ' Try wrapping in a conditional, i.e. `if (event.type !== "press") { event.stopPropagation() }`',
862
- {withoutStack: true},
863
- );
840
expect(() => {
841
handler = event => {
842
event.isDefaultPrevented();