Revert "Add helpful message about pooled classes"
This reverts commit e65f17b86cdfbe04453766161d5159203e672a7f. This might have a perf impact so we're not going to go with it for now.
Ben Alpert committed
Jul 11, 2014 at 16:00 UTC
92d2dcc25fa049d125a2c0dc82a98e1ce98e1a89
1 file changed
+12
-29
src/utils/PooledClass.js
+12
-29
@@ -20,14 +20,6 @@
20
21
var invariant = require('invariant');
22
23
-var ABOUT_POOLING_MESSAGE = null;
24
-if (__DEV__) {
25
- ABOUT_POOLING_MESSAGE = (
26
- 'This object is reused for performance reasons. If you\'re seeing this ' +
27
- 'after logging an object, try logging individual properties.'
28
- );
29
-}
30
-
23
/**
24
* Static poolers. Several custom versions for each potential number of
25
* arguments. A completely generic pooler is easy to implement, but would
@@ -37,54 +29,46 @@ if (__DEV__) {
29
*/
30
var oneArgumentPooler = function(copyFieldsFrom) {
31
var Klass = this;
40
- var instance;
32
if (Klass.instancePool.length) {
42
- instance = Klass.instancePool.pop();
33
+ var instance = Klass.instancePool.pop();
34
Klass.call(instance, copyFieldsFrom);
35
+ return instance;
36
} else {
45
- instance = new Klass(copyFieldsFrom);
37
+ return new Klass(copyFieldsFrom);
38
}
47
- instance._ABOUT_POOLING = null;
48
- return instance;
39
};
40
41
var twoArgumentPooler = function(a1, a2) {
42
var Klass = this;
53
- var instance;
43
if (Klass.instancePool.length) {
55
- instance = Klass.instancePool.pop();
44
+ var instance = Klass.instancePool.pop();
45
Klass.call(instance, a1, a2);
46
+ return instance;
47
} else {
58
- instance = new Klass(a1, a2);
48
+ return new Klass(a1, a2);
49
}
60
- instance._ABOUT_POOLING = null;
61
- return instance;
50
};
51
52
var threeArgumentPooler = function(a1, a2, a3) {
53
var Klass = this;
66
- var instance;
54
if (Klass.instancePool.length) {
68
- instance = Klass.instancePool.pop();
55
+ var instance = Klass.instancePool.pop();
56
Klass.call(instance, a1, a2, a3);
57
+ return instance;
58
} else {
71
- instance = new Klass(a1, a2, a3);
59
+ return new Klass(a1, a2, a3);
60
}
73
- instance._ABOUT_POOLING = null;
74
- return instance;
61
};
62
63
var fiveArgumentPooler = function(a1, a2, a3, a4, a5) {
64
var Klass = this;
79
- var instance;
65
if (Klass.instancePool.length) {
81
- instance = Klass.instancePool.pop();
66
+ var instance = Klass.instancePool.pop();
67
Klass.call(instance, a1, a2, a3, a4, a5);
68
+ return instance;
69
} else {
84
- instance = new Klass(a1, a2, a3, a4, a5);
70
+ return new Klass(a1, a2, a3, a4, a5);
71
}
86
- instance._ABOUT_POOLING = null;
87
- return instance;
72
};
73
74
var standardReleaser = function(instance) {
@@ -96,7 +80,6 @@ var standardReleaser = function(instance) {
80
if (instance.destructor) {
81
instance.destructor();
82
}
99
- instance._ABOUT_POOLING = ABOUT_POOLING_MESSAGE;
83
if (Klass.instancePool.length < Klass.poolSize) {
84
Klass.instancePool.push(instance);
85
}