Avoid NPE in Agent if renderer can't be found for an ID
Brian Vaughn committed
Feb 14, 2019 at 08:13 UTC
94aab74253142b4468f38253178c2d7ca80f1a15
1 file changed
+4
-2
src/backend/agent.js
+4
-2
@@ -73,16 +73,18 @@ export default class Agent extends EventEmitter {
73
const renderer = this._rendererInterfaces[rendererID];
74
if (renderer == null) {
75
console.warn(`Invalid renderer id "${rendererID}" for element "${id}"`);
76
+ } else {
77
+ this._bridge.send('inspectedElement', renderer.inspectElement(id));
78
}
77
- this._bridge.send('inspectedElement', renderer.inspectElement(id));
79
};
80
81
selectElement = ({ id, rendererID }: { id: number, rendererID: number }) => {
82
const renderer = this._rendererInterfaces[rendererID];
83
if (renderer == null) {
84
console.warn(`Invalid renderer id "${rendererID}" for element "${id}"`);
85
+ } else {
86
+ this._bridge.send('selectElement', renderer.selectElement(id));
87
}
85
- this._bridge.send('selectElement', renderer.selectElement(id));
88
};
89
90
setRendererInterface(