Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (#31761)
This flag controls the strict mode double invoke render/lifecycles/etc behavior in Strict Mode. The only place this flag is off is the test renderers, which it should be on for. If we can land this, we can follow up to remove the flag.
Ricky committed
Dec 16, 2024 at 22:52 UTC
975cea2d3ddb95ad31f10ae112bdde5101725c85
3 files changed
+3
-3
packages/shared/forks/ReactFeatureFlags.test-renderer.js
+1
-1
@@ -10,7 +10,7 @@
10
import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
11
import typeof * as ExportsType from './ReactFeatureFlags.test-renderer';
12
13
-export const debugRenderPhaseSideEffectsForStrictMode = false;
13
+export const debugRenderPhaseSideEffectsForStrictMode = __DEV__;
14
export const enableAsyncDebugInfo = false;
15
export const enableSchedulingProfiler = false;
16
export const enableProfilerTimer = __PROFILE__;
packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js
+1
-1
@@ -11,7 +11,7 @@ import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
11
import typeof * as ExportsType from './ReactFeatureFlags.test-renderer';
12
13
export const alwaysThrottleRetries = false;
14
-export const debugRenderPhaseSideEffectsForStrictMode = false;
14
+export const debugRenderPhaseSideEffectsForStrictMode = __DEV__;
15
export const disableClientCache = true;
16
export const disableCommentsAsDOMContainers = true;
17
export const disableDefaultPropsExceptForClasses = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
+1
-1
@@ -10,7 +10,7 @@
10
import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
11
import typeof * as ExportsType from './ReactFeatureFlags.test-renderer.www';
12
13
-export const debugRenderPhaseSideEffectsForStrictMode = false;
13
+export const debugRenderPhaseSideEffectsForStrictMode = __DEV__;
14
export const enableAsyncDebugInfo = false;
15
export const enableSchedulingProfiler = false;
16
export const enableProfilerTimer = __PROFILE__;